SORMAS-Foundation#3413 use Date::after and Date::before for comparing dates

Author: lgal

sormas-api/src/main/java/de/symeda/sormas/api/i18n/Captions.java

@@ -1110,6 +1110,7 @@ public interface Captions {
 	String Person_approximateAge = "Person.approximateAge";
 	String Person_approximateAgeReferenceDate = "Person.approximateAgeReferenceDate";
 	String Person_approximateAgeType = "Person.approximateAgeType";
+	String Person_armedForcesRelationType = "Person.armedForcesRelationType";
 	String Person_birthdate = "Person.birthdate";
 	String Person_birthdateDD = "Person.birthdateDD";
 	String Person_birthdateMM = "Person.birthdateMM";

sormas-app/app/src/main/java/de/symeda/sormas/app/component/validation/ValidationHelper.java

@@ -18,7 +18,7 @@ public static void initDateIntervalValidator(ControlDateField dateFromControl, C
 
 		ResultCallback<Boolean> dateFromCallback = () -> {
 			if (dateFromControl.getValue() != null && dateUntilContol.getValue() != null) {
-				if (DateTimeComparator.getDateOnlyInstance().compare(dateFromControl.getValue(), dateUntilContol.getValue()) > 0) {
+				if (dateFromControl.getValue().after(dateUntilContol.getValue())) {
 					dateFromControl.enableErrorState(
 						I18nProperties.getValidationError(Validations.beforeDate, dateFromControl.getCaption(), dateUntilContol.getCaption()));
 					return true;
@@ -30,7 +30,7 @@ public static void initDateIntervalValidator(ControlDateField dateFromControl, C
 
 		ResultCallback<Boolean> dateUntilCallback = () -> {
 			if (dateUntilContol.getValue() != null && dateFromControl.getValue() != null) {
-				if (DateTimeComparator.getDateOnlyInstance().compare(dateUntilContol.getValue(), dateFromControl.getValue()) < 0) {
+				if (dateUntilContol.getValue().before(dateFromControl.getValue())) {
 					dateUntilContol.enableErrorState(
 						I18nProperties.getValidationError(Validations.beforeDate, dateUntilContol.getCaption(), dateFromControl.getCaption()));
 					return true;