Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

Commit 3041648

Browse files
author
barnabartha
committed
SORMAS-Foundation#3221 (and SORMAS-Foundation#3214) - fix issues created by nullableoptiongroup
1 parent 8e3fc9a commit 3041648

7 files changed

Lines changed: 10 additions & 8 deletions

File tree

sormas-ui/src/main/java/de/symeda/sormas/ui/action/ActionEditForm.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import static de.symeda.sormas.ui.utils.LayoutUtil.locs;
2525

2626
import com.vaadin.v7.ui.ComboBox;
27+
import com.vaadin.v7.ui.Field;
2728
import com.vaadin.v7.ui.Label;
2829
import com.vaadin.v7.ui.RichTextArea;
2930
import com.vaadin.v7.ui.TextField;
@@ -161,7 +162,8 @@ private void updateByCreating() {
161162
}
162163

163164
private void updateByActionContext() {
164-
ActionContext actionContext = (ActionContext) getFieldGroup().getField(ActionDto.ACTION_CONTEXT).getValue();
165+
NullableOptionGroup field = (NullableOptionGroup) getFieldGroup().getField(ActionDto.ACTION_CONTEXT);
166+
ActionContext actionContext = (ActionContext) field.getNullableValue();
165167

166168
// context reference depending on action context
167169
// ready for adding new context

sormas-ui/src/main/java/de/symeda/sormas/ui/campaign/campaigndata/CampaignFormBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,8 @@ private boolean fieldValueMatchesDependingOnValues(Field<?> dependingOnField, Li
309309
}
310310

311311
if (dependingOnField instanceof NullableOptionGroup) {
312-
String booleanValue = Boolean.TRUE.equals(dependingOnField.getValue()) ? "true" : "false";
313-
String stringValue = Boolean.TRUE.equals(dependingOnField.getValue()) ? "yes" : "no";
312+
String booleanValue = Boolean.TRUE.equals(((NullableOptionGroup) dependingOnField).getNullableValue()) ? "true" : "false";
313+
String stringValue = Boolean.TRUE.equals(((NullableOptionGroup) dependingOnField).getNullableValue()) ? "yes" : "no";
314314

315315
return dependingOnValuesList.stream()
316316
.anyMatch(v -> v.toString().equalsIgnoreCase(booleanValue) || v.toString().equalsIgnoreCase(stringValue));

sormas-ui/src/main/java/de/symeda/sormas/ui/caze/BulkCaseDataForm.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ protected void addFields() {
310310
warningLayout = VaadinUiUtil.createWarningComponent(I18nProperties.getString(Strings.pseudonymizedCasesSelectedWarning));
311311
facilityOrHome.addValueChangeListener(e -> {
312312
FieldHelper.removeItems(facility);
313-
if (TypeOfPlace.FACILITY.equals(facilityOrHome.getValue())) {
313+
if (TypeOfPlace.FACILITY.equals(facilityOrHome.getNullableValue())) {
314314
if (facilityTypeGroup.getValue() == null) {
315315
facilityTypeGroup.setValue(FacilityTypeGroup.MEDICAL_FACILITY);
316316
}

sormas-ui/src/main/java/de/symeda/sormas/ui/caze/CaseCreateForm.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ protected void addFields() {
205205
.updateItems(district, regionDto != null ? FacadeProvider.getDistrictFacade().getAllActiveByRegion(regionDto.getUuid()) : null);
206206
});
207207
district.addValueChangeListener(e -> {
208-
if (!TypeOfPlace.HOME.equals(facilityOrHome.getValue())) {
208+
if (!TypeOfPlace.HOME.equals(facilityOrHome.getNullableValue())) {
209209
FieldHelper.removeItems(facility);
210210
}
211211
FieldHelper.removeItems(community);

sormas-ui/src/main/java/de/symeda/sormas/ui/caze/CaseDataForm.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ protected void addFields() {
475475
facility));
476476
facilityOrHome.addValueChangeListener(e -> {
477477
FieldHelper.removeItems(facility);
478-
if (TypeOfPlace.FACILITY.equals(facilityOrHome.getValue())) {
478+
if (TypeOfPlace.FACILITY.equals(facilityOrHome.getNullableValue())) {
479479

480480
// default values
481481
if (facilityTypeGroup.getValue() == null && !facilityTypeGroup.isReadOnly()) {

sormas-ui/src/main/java/de/symeda/sormas/ui/hospitalization/HospitalizationForm.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ protected void addFields() {
229229

230230
private void setDateFieldVisibilties() {
231231

232-
boolean visible = YesNoUnknown.YES.equals(intensiveCareUnit.getValue());
232+
boolean visible = YesNoUnknown.YES.equals(intensiveCareUnit.getNullableValue());
233233
intensiveCareUnitStart.setVisible(visible);
234234
intensiveCareUnitEnd.setVisible(visible);
235235
}

sormas-ui/src/main/java/de/symeda/sormas/ui/symptoms/SymptomsForm.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -902,7 +902,7 @@ private void addSoftRequiredStyleWhenSymptomaticAndCooperative(
902902
}
903903

904904
if (visitStatusField != null) {
905-
if (isAnySymptomSetToYes(fieldGroup, sourcePropertyIds, sourceValues) && visitStatusField.getValue() == VisitStatus.COOPERATIVE) {
905+
if (isAnySymptomSetToYes(fieldGroup, sourcePropertyIds, sourceValues) && visitStatusField.getNullableValue() == VisitStatus.COOPERATIVE) {
906906
FieldHelper.addSoftRequiredStyle(targetField);
907907
} else {
908908
FieldHelper.removeSoftRequiredStyle(targetField);

0 commit comments

Comments
 (0)