SORMAS-Foundation#4133 Avoid mocking of InvocationContext

Author: Stefan Kock

sormas-backend/src/main/java/de/symeda/sormas/backend/util/PerformanceLoggingInterceptor.java

@@ -58,12 +58,19 @@ public Object logInvokeDuration(InvocationContext context) throws Exception {
 	 */
 	static String getInvokedMethod(InvocationContext context) {
 
-		String targetName = context.getTarget().toString();
+		return getInvokedMethod(context.getTarget().toString(), context.getMethod().getName());
+	}
+
+	/**
+	 * @return Better readable method name (with EJB class) that was invoked.
+	 */
+	static String getInvokedMethod(String targetName, String methodName) {
+
 		int classBegin = targetName.lastIndexOf(".") + 1;
 		int innerClassBegin = targetName.indexOf("$");
 		int instanceBegin = targetName.indexOf("@");
 
 		String ejbName = targetName.substring(classBegin, innerClassBegin > 0 ? innerClassBegin : instanceBegin);
-		return String.format("%s.%s", ejbName, context.getMethod().getName());
+		return String.format("%s.%s", ejbName, methodName);
 	}
 }

sormas-backend/src/test/java/de/symeda/sormas/backend/util/PerformanceLoggingInterceptorTest.java

@@ -2,12 +2,6 @@
 
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.equalTo;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-
-import java.lang.reflect.Method;
-
-import javax.interceptor.InvocationContext;
 
 import org.junit.Test;
 
@@ -17,18 +11,19 @@
  */
 public class PerformanceLoggingInterceptorTest {
 
+	/**
+	 * Only tests the String inspection but avoids mocking due to massive performance impacts on other unit tests in the same test run.
+	 */
 	@Test
 	public void testGetInvokedMethod() {
 
-		InvocationContext context = mock(InvocationContext.class);
-		Method method = mock(Method.class);
-		when(context.getMethod()).thenReturn(method);
-
-		when(context.getTarget()).thenReturn("de.symeda.sormas.backend.region.CommunityService@15301bba");
-		when(context.getMethod().getName()).thenReturn("count");
-		assertThat(PerformanceLoggingInterceptor.getInvokedMethod(context), equalTo("CommunityService.count"));
+		assertThat(
+			PerformanceLoggingInterceptor.getInvokedMethod("de.symeda.sormas.backend.region.CommunityService@15301bba", "count"),
+			equalTo("CommunityService.count"));
 
-		when(context.getTarget()).thenReturn("de.symeda.sormas.backend.facility.FacilityFacadeEjb$FacilityFacadeEjbLocal@630e5556");
-		assertThat(PerformanceLoggingInterceptor.getInvokedMethod(context), equalTo("FacilityFacadeEjb.count"));
+		assertThat(
+			PerformanceLoggingInterceptor
+				.getInvokedMethod("de.symeda.sormas.backend.facility.FacilityFacadeEjb$FacilityFacadeEjbLocal@630e5556", "count"),
+			equalTo("FacilityFacadeEjb.count"));
 	}
 }