Skip to content

Commit e5d527b

Browse files
author
Bartosz Golaszewski
committed
gpio: swnode: don't use the swnode's name as the key for GPIO lookup
Looking up a GPIO controller by label that is the name of the software node is wonky at best - the GPIO controller driver is free to set a different label than the name of its firmware node. We're already being passed a firmware node handle attached to the GPIO device to swnode_get_gpio_device() so use it instead for a more precise lookup. Acked-by: Linus Walleij <[email protected]> Fixes: e7f9ff5 ("gpiolib: add support for software nodes") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bartosz Golaszewski <[email protected]>
1 parent 4a37279 commit e5d527b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpio/gpiolib-swnode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ static struct gpio_device *swnode_get_gpio_device(struct fwnode_handle *fwnode)
4141
!strcmp(gdev_node->name, GPIOLIB_SWNODE_UNDEFINED_NAME))
4242
return ERR_PTR(-ENOENT);
4343

44-
gdev = gpio_device_find_by_label(gdev_node->name);
44+
gdev = gpio_device_find_by_fwnode(fwnode);
4545
return gdev ?: ERR_PTR(-EPROBE_DEFER);
4646
}
4747

0 commit comments

Comments
 (0)