Skip to content

Commit c91afa7

Browse files
committed
tracing: tprobe-events: Fix to put tracepoint_user when disable the tprobe
__unregister_trace_fprobe() checks tf->tuser to put it when removing tprobe. However, disable_trace_fprobe() does not use it and only calls unregister_fprobe(). Thus it forgets to disable tracepoint_user. If the trace_fprobe has tuser, put it for unregistering the tracepoint callbacks when disabling tprobe correctly. Link: https://lore.kernel.org/all/176244794466.155515.3971904050506100243.stgit@devnote2/ Fixes: 2867495 ("tracing: tprobe-events: Register tracepoint when enable tprobe event") Cc: [email protected] Signed-off-by: Masami Hiramatsu (Google) <[email protected]> Tested-by: Beau Belgrave <[email protected]> Reviewed-by: Beau Belgrave <[email protected]>
1 parent 10d9dda commit c91afa7

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

kernel/trace/trace_fprobe.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1514,6 +1514,10 @@ static int disable_trace_fprobe(struct trace_event_call *call,
15141514
if (!trace_probe_is_enabled(tp)) {
15151515
list_for_each_entry(tf, trace_probe_probe_list(tp), tp.list) {
15161516
unregister_fprobe(&tf->fp);
1517+
if (tf->tuser) {
1518+
tracepoint_user_put(tf->tuser);
1519+
tf->tuser = NULL;
1520+
}
15171521
}
15181522
}
15191523

0 commit comments

Comments
 (0)