Skip to content

Commit c667c54

Browse files
micromaomaomartinetd
authored andcommitted
fs/9p: Add p9_debug(VFS) in d_revalidate
This was a useful debugging / validation aid, and can explain why a GETATTR request is made. Signed-off-by: Tingmao Wang <[email protected]> Message-ID: <00829a99549e33d26139fa4d756c466629f13e00.1743956147.git.m@maowtm.org> Signed-off-by: Dominique Martinet <[email protected]>
1 parent 0172a93 commit c667c54

1 file changed

Lines changed: 20 additions & 4 deletions

File tree

fs/9p/vfs_dentry.c

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,13 @@ static int __v9fs_lookup_revalidate(struct dentry *dentry, unsigned int flags)
8585
struct v9fs_session_info *v9ses;
8686

8787
fid = v9fs_fid_lookup(dentry);
88-
if (IS_ERR(fid))
88+
if (IS_ERR(fid)) {
89+
p9_debug(
90+
P9_DEBUG_VFS,
91+
"v9fs_fid_lookup: dentry = %pd (%p), got error %pe\n",
92+
dentry, dentry, fid);
8993
return PTR_ERR(fid);
94+
}
9095

9196
v9ses = v9fs_inode2v9ses(inode);
9297
if (v9fs_proto_dotl(v9ses))
@@ -95,14 +100,25 @@ static int __v9fs_lookup_revalidate(struct dentry *dentry, unsigned int flags)
95100
retval = v9fs_refresh_inode(fid, inode);
96101
p9_fid_put(fid);
97102

98-
if (retval == -ENOENT)
103+
if (retval == -ENOENT) {
104+
p9_debug(P9_DEBUG_VFS, "dentry: %pd (%p) invalidated due to ENOENT\n",
105+
dentry, dentry);
99106
return 0;
100-
if (v9inode->cache_validity & V9FS_INO_INVALID_ATTR)
107+
}
108+
if (v9inode->cache_validity & V9FS_INO_INVALID_ATTR) {
109+
p9_debug(P9_DEBUG_VFS, "dentry: %pd (%p) invalidated due to type change\n",
110+
dentry, dentry);
101111
return 0;
102-
if (retval < 0)
112+
}
113+
if (retval < 0) {
114+
p9_debug(P9_DEBUG_VFS,
115+
"refresh inode: dentry = %pd (%p), got error %pe\n",
116+
dentry, dentry, ERR_PTR(retval));
103117
return retval;
118+
}
104119
}
105120
out_valid:
121+
p9_debug(P9_DEBUG_VFS, "dentry: %pd (%p) is valid\n", dentry, dentry);
106122
return 1;
107123
}
108124

0 commit comments

Comments
 (0)