usb: dwc3: Don't call clk_bulk_disable_unprepare() twice

tititiou36 · gregkh · commit 2758246d2875 · 2025-10-13T09:37:10.000+02:00
devm_clk_bulk_get_all_enabled() is used in the probe, so clk_bulk_disable_unprepare() should not be called explicitly in the remove function. Fixes: e0b6dc0 ("usb: dwc3: add generic driver to support flattened") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/dwc3/dwc3-generic-plat.c b/drivers/usb/dwc3/dwc3-generic-plat.c
@@ -85,11 +85,8 @@ static int dwc3_generic_probe(struct platform_device *pdev)
 static void dwc3_generic_remove(struct platform_device *pdev)
 {
 	struct dwc3 *dwc = platform_get_drvdata(pdev);
-	struct dwc3_generic *dwc3g = to_dwc3_generic(dwc);
 
 	dwc3_core_remove(dwc);
-
-	clk_bulk_disable_unprepare(dwc3g->num_clocks, dwc3g->clks);
 }
 
 static int dwc3_generic_suspend(struct device *dev)

Original file line number	Diff line number	Diff line change
`@@ -85,11 +85,8 @@ static int dwc3_generic_probe(struct platform_device *pdev)`
`85`	`85`	`static void dwc3_generic_remove(struct platform_device *pdev)`
`86`	`86`	`{`
`87`	`87`	`struct dwc3 *dwc = platform_get_drvdata(pdev);`
`88`		`- struct dwc3_generic *dwc3g = to_dwc3_generic(dwc);`
`89`	`88`
`90`	`89`	`dwc3_core_remove(dwc);`
`91`		`-`
`92`		`- clk_bulk_disable_unprepare(dwc3g->num_clocks, dwc3g->clks);`
`93`	`90`	`}`
`94`	`91`
`95`	`92`	`static int dwc3_generic_suspend(struct device *dev)`