Skip to content

Commit 092b9e2

Browse files
cris-masudeep-holla
authored andcommitted
firmware: arm_scmi: Skip RAW initialization on failure
Avoid attempting to initialize RAW mode when the debug subsystem itself has failed to initialize, since doing so is pointless and emits misleading error messages. Signed-off-by: Cristian Marussi <[email protected]> Message-Id: <[email protected]> Signed-off-by: Sudeep Holla <[email protected]>
1 parent 289ce7e commit 092b9e2

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

drivers/firmware/arm_scmi/driver.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3028,9 +3028,6 @@ static int scmi_debugfs_raw_mode_setup(struct scmi_info *info)
30283028
u8 channels[SCMI_MAX_CHANNELS] = {};
30293029
DECLARE_BITMAP(protos, SCMI_MAX_CHANNELS) = {};
30303030

3031-
if (!info->dbg)
3032-
return -EINVAL;
3033-
30343031
/* Enumerate all channels to collect their ids */
30353032
idr_for_each_entry(&info->tx_idr, cinfo, id) {
30363033
/*
@@ -3202,7 +3199,7 @@ static int scmi_probe(struct platform_device *pdev)
32023199
if (!info->dbg)
32033200
dev_warn(dev, "Failed to setup SCMI debugfs.\n");
32043201

3205-
if (IS_ENABLED(CONFIG_ARM_SCMI_RAW_MODE_SUPPORT)) {
3202+
if (info->dbg && IS_ENABLED(CONFIG_ARM_SCMI_RAW_MODE_SUPPORT)) {
32063203
ret = scmi_debugfs_raw_mode_setup(info);
32073204
if (!coex) {
32083205
if (ret)

0 commit comments

Comments
 (0)