Merge pull request #11 from JakeGinnivan/Publish

Publish

Author: JakeGinnivan

.gitattributes

@@ -43,6 +43,7 @@
 #*.jpg   binary
 #*.png   binary
 #*.gif   binary
+*.approved.txt   binary
 
 ###############################################################################
 # diff behavior for common document formats

.gitignore

@@ -109,3 +109,4 @@ UpgradeLog*.XML
 build/
 src/GitReleaseNotes.sln.ide/graph
 *.orig
+src/_NCrunch_GitReleaseNotes

src/GitReleaseNotes.Tests/GitReleaseNotes.Tests.csproj

@@ -59,14 +59,18 @@
     <Reference Include="xunit">
       <HintPath>..\packages\xunit.1.9.2\lib\net20\xunit.dll</HintPath>
     </Reference>
+    <Reference Include="xunit.extensions">
+      <HintPath>..\packages\xunit.extensions.1.9.2\lib\net20\xunit.extensions.dll</HintPath>
+    </Reference>
   </ItemGroup>
   <ItemGroup>
     <Compile Include="ArgumentTests.cs" />
     <Compile Include="CommitGrouperTests.cs" />
     <Compile Include="IssueTrackers\GitHub\GitHubIssueTrackerTests.cs" />
     <Compile Include="IssueTrackers\IssueNumberExtractor.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
-    <Compile Include="ReleaseNotesWriterTests.cs" />
+    <Compile Include="ReleaseFileWriterTests.cs" />
+    <Compile Include="ReleaseNotesGeneratorTests.cs" />
   </ItemGroup>
   <ItemGroup>
     <None Include="packages.config" />

src/GitReleaseNotes.Tests/IssueTrackers/GitHub/GitHubIssueTrackerTests.cs

@@ -7,6 +7,7 @@
 using NSubstitute;
 using Octokit;
 using Xunit;
+using Xunit.Extensions;
 
 namespace GitReleaseNotes.Tests.IssueTrackers.GitHub
 {
@@ -16,11 +17,13 @@ public class GitHubIssueTrackerTests
         private readonly GitHubIssueTracker _sut;
         private readonly GitReleaseNotesArguments _gitReleaseNotesArguments;
         private readonly IIssuesClient _issuesClient;
+        private readonly ILog _log;
 
         public GitHubIssueTrackerTests()
         {
+            _log = Substitute.For<ILog>();
             _gitHubClient = Substitute.For<IGitHubClient>();
-            _sut = new GitHubIssueTracker(new IssueNumberExtractor(), _gitHubClient);
+            _sut = new GitHubIssueTracker(new IssueNumberExtractor(), () => _gitHubClient, _log);
             _gitReleaseNotesArguments = new GitReleaseNotesArguments
             {
                 Repo = "Org/Repo",
@@ -55,6 +58,64 @@ public void CreatesReleaseNotesForClosedGitHubIssues()
             Assert.Equal("Issue Title", releaseNotes.Releases[0].ReleaseNoteItems[0].Title);
         }
 
+        [Fact]
+        public void ErrorLoggedWhenRepoIsNotSpecified()
+        {
+            var result = _sut.VerifyArgumentsAndWriteErrorsToConsole(new GitReleaseNotesArguments());
+
+            Assert.False(result);
+            _log.Received().WriteLine("GitHub repository name must be specified [/Repo .../...]");
+        }
+
+        [Theory]
+        [InlineData("Foo", false)]
+        [InlineData("Org/Repo", true)]
+        [InlineData("Org/Repo/SomethingElse", false)]
+        public void RepositoryMustBeInCorrectFormat(string repo, bool success)
+        {
+            var result = _sut.VerifyArgumentsAndWriteErrorsToConsole(new GitReleaseNotesArguments
+            {
+                Repo = repo,
+                Token = "Foo"
+            });
+
+            if (success)
+            {
+                Assert.True(result);
+            }
+            else
+            {
+                Assert.False(result);
+                _log.Received().WriteLine("GitHub repository name should be in format Organisation/RepoName");
+            }
+        }
+
+        [Fact]
+        public void MustSpecifyToken()
+        {
+            var result = _sut.VerifyArgumentsAndWriteErrorsToConsole(new GitReleaseNotesArguments
+            {
+                Repo = "Foo/Bar"
+            });
+
+            Assert.False(result);
+            _log.Received().WriteLine("You must specify a GitHub Authentication token with the /Token argument");
+        }
+
+        [Fact]
+        public void MustSpecifyVersionWhenPublishFlagIsSet()
+        {
+            var result = _sut.VerifyArgumentsAndWriteErrorsToConsole(new GitReleaseNotesArguments
+            {
+                Repo = "Foo/Bar",
+                Token = "Baz",
+                Publish = true
+            });
+
+            Assert.False(result);
+            _log.Received().WriteLine("You must specifiy the version [/Version ...] (will be tag) when using the /Publish flag");
+        }
+
         private static Commit CreateCommit(string message, DateTimeOffset when)
         {
             var commit = Substitute.For<Commit>();

src/GitReleaseNotes.Tests/ReleaseFileWriterTests.cs

@@ -0,0 +1,50 @@
+using System.IO;
+using System.Linq;
+using NSubstitute;
+using Xunit;
+
+namespace GitReleaseNotes.Tests
+{
+    public class ReleaseFileWriterTests
+    {
+        private readonly IFileSystem _fileSystem;
+        private const string RepositoryRoot = "c:\\Repo";
+        private readonly ReleaseFileWriter _sut;
+
+        public ReleaseFileWriterTests()
+        {
+            _fileSystem = Substitute.For<IFileSystem>();
+            _sut = new ReleaseFileWriter(_fileSystem, RepositoryRoot);
+        }
+
+        [Fact]
+        public void RelativePathIsWrittenToRepositoryRoot()
+        {
+            var arguments = new GitReleaseNotesArguments
+            {
+                Categories = "internal refactoring",
+                OutputFile = "ReleaseFile.md"
+            };
+
+            _sut.OutputReleaseNotesFile(RepositoryRoot, arguments);
+
+            var fileName = _fileSystem.ReceivedCalls().Single(c => c.GetMethodInfo().Name == "WriteAllText").GetArguments()[0];
+            Assert.Equal(Path.Combine(RepositoryRoot, "ReleaseFile.md"), fileName);
+        }
+
+        [Fact]
+        public void AbsolutePathIsWrittenToRepositoryRoot()
+        {
+            var arguments = new GitReleaseNotesArguments
+            {
+                Categories = "internal refactoring",
+                OutputFile = "c:\\AnotherDir\\ReleaseFile.md"
+            };
+
+            _sut.OutputReleaseNotesFile(RepositoryRoot, arguments);
+
+            var fileName = _fileSystem.ReceivedCalls().Single(c => c.GetMethodInfo().Name == "WriteAllText").GetArguments()[0];
+            Assert.Equal("c:\\AnotherDir\\ReleaseFile.md", fileName);
+        }
+    }
+}

…abelOfBugIsCategorisedAsFix.approved.txt …abelOfBugIsCategorisedAsFix.approved.txtsrc/GitReleaseNotes.Tests/ReleaseNotesWriterTests.LabelOfBugIsCategorisedAsFix.approved.txt renamed to src/GitReleaseNotes.Tests/ReleaseNotesGenerator.LabelOfBugIsCategorisedAsFix.approved.txt src/GitReleaseNotes.Tests/ReleaseNotesWriterTests.LabelOfBugIsCategorisedAsFix.approved.txt renamed to src/GitReleaseNotes.Tests/ReleaseNotesGenerator.LabelOfBugIsCategorisedAsFix.approved.txt

@@ -0,0 +1 @@
+ - Issue 1 [#1](http://github.com/org/repo/issues/1) +fix