Skip to content
This repository was archived by the owner on Sep 20, 2022. It is now read-only.

Commit b3063cd

Browse files
author
Jérémie Bertrand
committed
Fix #105
1 parent 46a9afb commit b3063cd

2 files changed

Lines changed: 21 additions & 2 deletions

File tree

src/GitReleaseNotes.Tests/SemanticReleaseNotesTests.cs

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,5 +265,25 @@ public void CanReadReleaseNotesContainingMultipleReleases()
265265
readReleaseNotes.Releases[1].ReleaseNoteItems[0].Title.ShouldBe("Issue 2 [#2](http://github.com/org/repo/issues/2) +feature");
266266
readReleaseNotes.Releases[1].ReleaseNoteItems[1].Title.ShouldBe("Issue 3 [#3](http://github.com/org/repo/issues/3) +fix");
267267
}
268+
269+
[Fact]
270+
public void CanReadReleaseNotesWithXmlDateFormat()
271+
{
272+
const string releaseNotes = @"# v0.1.0 (2016-08-29)
273+
274+
- Issue 1 [#1](http://github.com/org/repo/issues/1) +feature +new
275+
276+
Commits: 12345678...67890123
277+
";
278+
var readReleaseNotes = SemanticReleaseNotes.Parse(releaseNotes);
279+
280+
readReleaseNotes.Releases.Length.ShouldBe(1);
281+
readReleaseNotes.Releases[0].DiffInfo.BeginningSha.ShouldBe("12345678");
282+
readReleaseNotes.Releases[0].DiffInfo.EndSha.ShouldBe("67890123");
283+
readReleaseNotes.Releases[0].ReleaseName.ShouldBe("v0.1.0");
284+
readReleaseNotes.Releases[0].When.ShouldBe(new DateTimeOffset(new DateTime(2016, 08, 29)));
285+
readReleaseNotes.Releases[0].ReleaseNoteLines.Count.ShouldBe(1);
286+
readReleaseNotes.Releases[0].ReleaseNoteItems[0].Title.ShouldBe("Issue 1 [#1](http://github.com/org/repo/issues/1) +feature +new");
287+
}
268288
}
269289
}

src/GitReleaseNotes/Models/SemanticReleaseNotes.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ public static SemanticReleaseNotes Parse(string releaseNotes)
122122
{
123123
currentRelease.When = parsed;
124124
}
125-
126-
if (DateTime.TryParseExact(toParse, "dd MMMM yyyy", CultureInfo.InvariantCulture,
125+
else if (DateTime.TryParseExact(toParse, "dd MMMM yyyy", CultureInfo.InvariantCulture,
127126
DateTimeStyles.None, out parsed))
128127
{
129128
currentRelease.When = parsed;

0 commit comments

Comments
 (0)