introduce a constexpr variable "bit_per_iteration" since it's a 8-bit radix sort

KaoCC · KaoCC · commit 34aa200aa70d · 2025-03-24T14:29:16.000+01:00
Signed-off-by: Chih-Chen Kao &lt;chihchen.kao@amd.com&gt;
diff --git a/ParallelPrimitives/RadixSort.cpp b/ParallelPrimitives/RadixSort.cpp
@@ -255,7 +255,9 @@ void RadixSort::sort( const KeyValueSoA& src, const KeyValueSoA& dst, uint32_t n
 		return;
 	}
 
-	int nIteration = div_round_up64( endBit - startBit, 8 );
+	constexpr uint64_t bit_per_iteration = 8ULL;
+
+	int nIteration = div_round_up64( endBit - startBit, bit_per_iteration);
 	uint64_t numberOfBlocks = div_round_up64( n, RADIX_SORT_BLOCK_SIZE );
 
 	m_lookbackBuffer.resetAsync( stream );
@@ -274,7 +276,7 @@ void RadixSort::sort( const KeyValueSoA& src, const KeyValueSoA& dst, uint32_t n
 
 	auto s = src;
 	auto d = dst;
-	for( int i = 0; i < nIteration; i++ )
+	for( int i = 0; i < nIteration; ++i )
 	{
 		if( numberOfBlocks < LOOKBACK_TABLE_SIZE * 2 )
 		{

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,9 @@ void RadixSort::sort( const KeyValueSoA& src, const KeyValueSoA& dst, uint32_t n`
`255`	`255`	`return;`
`256`	`256`	`}`
`257`	`257`
`258`		`- int nIteration = div_round_up64( endBit - startBit, 8 );`
	`258`	`+ constexpr uint64_t bit_per_iteration = 8ULL;`
	`259`	`+`
	`260`	`+ int nIteration = div_round_up64( endBit - startBit, bit_per_iteration);`
`259`	`261`	`uint64_t numberOfBlocks = div_round_up64( n, RADIX_SORT_BLOCK_SIZE );`
`260`	`262`
`261`	`263`	`m_lookbackBuffer.resetAsync( stream );`
`@@ -274,7 +276,7 @@ void RadixSort::sort( const KeyValueSoA& src, const KeyValueSoA& dst, uint32_t n`
`274`	`276`
`275`	`277`	`auto s = src;`
`276`	`278`	`auto d = dst;`
`277`		`- for( int i = 0; i < nIteration; i++ )`
	`279`	`+ for( int i = 0; i < nIteration; ++i )`
`278`	`280`	`{`
`279`	`281`	`if( numberOfBlocks < LOOKBACK_TABLE_SIZE * 2 )`
`280`	`282`	`{`