Skip to content

Commit a513107

Browse files
committed
Fix compilation error using SDK 6.3
Recent commit added support for gfx1152 but used an uninitialized variable `gpus_archs`. Follow the same code as for SDK 6.2 and use gpus.append() instead. --- This fixes the following compilation error: [ 3%] Precompiling kernels via compile.py Compile kernel using hip sdk: /opt/rocm HIP version: 6.3.42133-1b9c17779 AMD clang version 18.0.0git (https://github.com/RadeonOpenCompute/llvm-project roc-6.3.1 24491 1e0fda770a2079fbd71e4b70974d74f62fd3af10) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /opt/rocm-6.3.1/lib/llvm/bin Configuration file: /opt/rocm-6.3.1/lib/llvm/bin/clang++.cfg Traceback (most recent call last): File "/home/sergey/Developer/build_linux/deps_x64/build/hiprt/src/external_hiprt/scripts/bitcodes/compile.py", line 209, in <module> compileAmd() File "/home/sergey/Developer/build_linux/deps_x64/build/hiprt/src/external_hiprt/scripts/bitcodes/compile.py", line 103, in compileAmd gpus_archs.append('gfx1152') ^^^^^^^^^^ NameError: name 'gpus_archs' is not defined
1 parent 9452e5c commit a513107

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

scripts/bitcodes/compile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def compileAmd():
100100

101101

102102
if hip_sdk_version_num >= 63:
103-
gpus_archs.append('gfx1152')
103+
gpus.append('gfx1152')
104104

105105
if hip_sdk_version_num >= 62: # Navi4 supported from 6.2
106106
gpus.append('gfx1200')

scripts/bitcodes/precompile_bitcode.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def compileAmd():
107107

108108

109109
if hip_sdk_version_num >= 63:
110-
gpus_archs.append('gfx1152')
110+
gpus.append('gfx1152')
111111

112112
if hip_sdk_version_num >= 62: # Navi4 supported from 6.2
113113
gpus.append('gfx1200')

0 commit comments

Comments
 (0)