fix: enhance ProxySetHandlerTargetCheck to prevent infinite recursion with WeakSet (#228)

* fix: enhance ProxySetHandlerTargetCheck to prevent infinite recursion with WeakSet

* fix: remove `ProxySetHandlerTargetCheckAndReplace`

Author: piquark6046

userscript/source/index.ts

@@ -285,50 +285,31 @@ export function RunNamuLinkUserscript(BrowserWindow: typeof window, UserscriptNa
     return Stringified.includes('https://ader.naver.com/')
   }
 
-  function ProxySetHandlerTargetCheck(Target: object): boolean {
-    for (const PropertyName of Object.keys(Target)) {
-      const Value = (Target as Record<string, unknown>)[PropertyName]
-      const Descriptor = OriginalObjectGetOwnPropertyDescriptor(Target, PropertyName)
-
-      if (
-        typeof Value === 'object' &&
-        Value !== null &&
-        typeof Descriptor?.get !== 'function'
-      ) {
-        if (ProxySetHandlerTargetCheck(Value)) {
-          return true
-        }
-      } else if (
-        typeof Value === 'string' &&
-        Value.includes('ader.naver.com')
-      ) {
-        return true
-      }
+  function ProxySetHandlerTargetCheck(
+    Target: object,
+    Visited = new WeakSet<object>()
+  ): boolean {
+    if (Visited.has(Target)) {
+      return false
     }
+    Visited.add(Target)
 
-    return false
-  }
-
-  function ProxySetHandlerTargetCheckAndReplace(Target: object, NewValue: string): boolean {
-    const Record = Target as Record<string, unknown>
-
-    for (const PropertyName of Object.keys(Record)) {
-      const Value = Record[PropertyName]
+    for (const PropertyName of Object.keys(Target)) {
+      const Value = (Target as Record<string, unknown>)[PropertyName]
       const Descriptor = OriginalObjectGetOwnPropertyDescriptor(Target, PropertyName)
 
       if (
         typeof Value === 'object' &&
         Value !== null &&
         typeof Descriptor?.get !== 'function'
       ) {
-        if (ProxySetHandlerTargetCheckAndReplace(Value, NewValue)) {
+        if (ProxySetHandlerTargetCheck(Value, Visited)) {
           return true
         }
       } else if (
         typeof Value === 'string' &&
         Value.includes('ader.naver.com')
       ) {
-        Record[PropertyName] = NewValue
         return true
       }
     }
@@ -438,9 +419,6 @@ export function RunNamuLinkUserscript(BrowserWindow: typeof window, UserscriptNa
             BrowserWindow.document.dispatchEvent(new CustomEvent('PL2PlaceHolderProxy'))
             return
           }
-          else if (ProxySetHandlerTargetCheckAndReplace(SetArgs[0], '')) {
-            console.debug(`[${UserscriptName}]: Proxy set called for PowerLink Skeleton (target check and replace):`, SetArgs)
-          }
           return OriginalReflectApply(OriginalSet, this, SetArgs)
         }
       }