Set pyspark launch path based on OS

Author: shengyfu

package.json

@@ -419,7 +419,7 @@
             "type": "python",
             "request": "launch",
             "stopOnEntry": true,
-            "pythonPath": "${env.SPARK_HOME}/bin/spark-submit",
+            "pythonPath": "${config.python.pysparkPath}",
             "program": "${file}",
             "cwd": "${workspaceRoot}",
             "debugOptions": [
@@ -567,6 +567,11 @@
           "default": "python",
           "description": "Path to Python, you can use a custom version of Python by modifying this setting to include the full path."
         },
+        "python.pysparkPath": {
+          "type": "string",
+          "default": "${env.SPARK_HOME}/bin/spark-submit",
+          "description": "Path to spark-submit executable, you can use a custom version of Spark by modifying this setting to include the full path."
+        },
         "python.jediPath": {
           "type": "string",
           "default": "",

src/client/providers/updateSparkLibraryProvider.ts

@@ -2,6 +2,7 @@
 import { Commands } from '../common/constants';
 import * as vscode from "vscode";
 import * as path from 'path';
+import { IS_WINDOWS } from '../common/utils';
 
 export function activateUpdateSparkLibraryProvider(): vscode.Disposable {
     console.log('Register command python.updateSparkLibrary');
@@ -19,4 +20,14 @@ function updateSparkLibrary() {
         vscode.window.showErrorMessage(`Failed to update ${extraLibPath}. Error: ${reason.message}`);
         console.error(reason);
     });
+    if (IS_WINDOWS) {        
+        const pysparkPath = 'pysparkPath';
+        console.log('Overriding ' + pysparkPath);
+        pythonConfig.update(pysparkPath, path.join(sparkHomePath, 'bin', 'spark-submit.cmd')).then(() => {
+        //Done
+        }, reason => {
+            vscode.window.showErrorMessage(`Failed to update ${pysparkPath}. Error: ${reason.message}`);
+            console.error(reason);
+        });
+    }
 }