Skip to content

Commit 093a6aa

Browse files
committed
fix #485
1 parent d74e936 commit 093a6aa

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

src/client/jupyter/kernel-manager.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,8 @@ export class KernelManagerImpl extends EventEmitter {
2121
this.disposables = [];
2222
this._runningKernels = new Map<string, Kernel>();
2323
this._kernelSpecs = {};
24-
this.registerCommands();
2524
}
2625

27-
private registerCommands() {
28-
this.disposables.push(vscode.commands.registerCommand(Commands.Jupyter.Get_All_KernelSpecs_For_Language, this.getAllKernelSpecsFor.bind(this)));
29-
this.disposables.push(vscode.commands.registerCommand(Commands.Jupyter.StartKernelForKernelSpeck, this.startKernel.bind(this)));
30-
}
3126
public dispose() {
3227
this.removeAllListeners();
3328
this._runningKernels.forEach(kernel => {

src/client/jupyter/main.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import * as main from './jupyter_client/main';
1414
import { KernelRestartedError, KernelShutdownError } from './common/errors';
1515
import { PythonSettings } from '../common/configSettings';
1616
import { CodeHelper } from './common/codeHelper';
17+
import { KernelspecMetadata } from './contracts';
1718

1819
const pythonSettings = PythonSettings.getInstance();
1920

@@ -183,6 +184,18 @@ export class Jupyter extends vscode.Disposable {
183184
}));
184185
this.disposables.push(vscode.commands.registerCommand(Commands.Jupyter.ExecuteSelectionOrLineInKernel,
185186
this.executeSelection.bind(this)));
187+
this.disposables.push(vscode.commands.registerCommand(Commands.Jupyter.Get_All_KernelSpecs_For_Language, (language: string) => {
188+
if (this.kernelManager) {
189+
return this.kernelManager.getAllKernelSpecsFor(language);
190+
}
191+
return Promise.resolve();
192+
}));
193+
this.disposables.push(vscode.commands.registerCommand(Commands.Jupyter.StartKernelForKernelSpeck, (kernelSpec: KernelspecMetadata, language: string) => {
194+
if (this.kernelManager) {
195+
return this.kernelManager.startKernel(kernelSpec, language);
196+
}
197+
return Promise.resolve();
198+
}));
186199
}
187200
private registerKernelCommands() {
188201
this.disposables.push(vscode.commands.registerCommand(Commands.Jupyter.Kernel.Kernel_Interrupt, () => {

0 commit comments

Comments
 (0)