Optimize SPV_EXT_opacity_micromap and SPV_EXT_shader_invocation_reorder (KhronosGroup#6571)

It's been a while since I last added extensions to these lists, but I
just ran into a long-forgotten related issue again that DXC outputs
invalid SPIR-V before it's stripped away by `spirv-opt`:
microsoft/DirectXShaderCompiler#8210.

Shaders with these extensions weren't yet extensively tested but this at
least gets us past `spir-val` in both DXC (can also be disabled with
`-Vd`) and the validation layers.

---

I'm probably way out of my league to ask, but is there still much
significance to `extensions_allowlist_`? It seems like a maintenance
burden that's very easy to miss, for (currently) a single extension
that's specifically commented out to not be optimized.

It's also mostly duplicated but not entirely in sync across all 4 passes
either. I even noticed that `SPV_KHR_shader_clock` which **I added** to
`dead_code_elim_pass` in
KhronosGroup#4049 isn't in any other
file, which must have been an oversight on my part but also means that
presence of this extension erroneously disables all the other 3 passes.

Author: MarijnS95

source/opt/aggressive_dead_code_elim_pass.cpp

@@ -1137,13 +1137,13 @@ void AggressiveDCEPass::InitExtensions() {
       "SPV_KHR_physical_storage_buffer",
       "SPV_KHR_terminate_invocation",
       "SPV_KHR_shader_clock",
-      "SPV_KHR_vulkan_memory_model",
       "SPV_KHR_subgroup_uniform_control_flow",
       "SPV_KHR_integer_dot_product",
       "SPV_EXT_shader_image_int64",
       "SPV_KHR_non_semantic_info",
       "SPV_KHR_uniform_group_instructions",
       "SPV_KHR_fragment_shader_barycentric",
+      "SPV_KHR_vulkan_memory_model",
       "SPV_NV_bindless_texture",
       "SPV_EXT_shader_atomic_float_add",
       "SPV_EXT_fragment_shader_interlock",
@@ -1158,6 +1158,8 @@ void AggressiveDCEPass::InitExtensions() {
       "SPV_NV_linear_swept_spheres",
       "SPV_KHR_maximal_reconvergence",
       "SPV_NV_push_constant_bank",
+      "SPV_EXT_opacity_micromap",
+      "SPV_EXT_shader_invocation_reorder",
   });
 }
 

source/opt/local_access_chain_convert_pass.cpp

@@ -448,6 +448,7 @@ void LocalAccessChainConvertPass::InitExtensions() {
       "SPV_KHR_ray_query",
       "SPV_EXT_fragment_invocation_density",
       "SPV_KHR_terminate_invocation",
+      "SPV_KHR_shader_clock",
       "SPV_KHR_subgroup_uniform_control_flow",
       "SPV_KHR_integer_dot_product",
       "SPV_EXT_shader_image_int64",
@@ -470,6 +471,8 @@ void LocalAccessChainConvertPass::InitExtensions() {
       "SPV_NV_linear_swept_spheres",
       "SPV_KHR_maximal_reconvergence",
       "SPV_NV_push_constant_bank",
+      "SPV_EXT_opacity_micromap",
+      "SPV_EXT_shader_invocation_reorder",
   });
 }
 

source/opt/local_single_block_elim_pass.cpp

@@ -241,7 +241,6 @@ void LocalSingleBlockLoadStoreElimPass::InitExtensions() {
       "SPV_AMD_gcn_shader",
       "SPV_KHR_shader_ballot",
       "SPV_AMD_shader_ballot",
-      "SPV_AMDX_shader_enqueue",
       "SPV_AMD_gpu_shader_half_float",
       "SPV_KHR_shader_draw_parameters",
       "SPV_KHR_subgroup_vote",
@@ -286,6 +285,7 @@ void LocalSingleBlockLoadStoreElimPass::InitExtensions() {
       "SPV_EXT_physical_storage_buffer",
       "SPV_KHR_physical_storage_buffer",
       "SPV_KHR_terminate_invocation",
+      "SPV_KHR_shader_clock",
       "SPV_KHR_subgroup_uniform_control_flow",
       "SPV_KHR_integer_dot_product",
       "SPV_EXT_shader_image_int64",
@@ -300,13 +300,16 @@ void LocalSingleBlockLoadStoreElimPass::InitExtensions() {
       "SPV_NV_cooperative_matrix",
       "SPV_KHR_cooperative_matrix",
       "SPV_KHR_ray_tracing_position_fetch",
+      "SPV_AMDX_shader_enqueue",
       "SPV_KHR_fragment_shading_rate",
       "SPV_KHR_quad_control",
       "SPV_NV_shader_invocation_reorder",
       "SPV_NV_cluster_acceleration_structure",
       "SPV_NV_linear_swept_spheres",
       "SPV_KHR_maximal_reconvergence",
       "SPV_NV_push_constant_bank",
+      "SPV_EXT_opacity_micromap",
+      "SPV_EXT_shader_invocation_reorder",
   });
 }
 

source/opt/local_single_store_elim_pass.cpp

@@ -120,6 +120,7 @@ void LocalSingleStoreElimPass::InitExtensionAllowList() {
       "SPV_AMD_gpu_shader_half_float_fetch",
       "SPV_GOOGLE_decorate_string",
       "SPV_GOOGLE_hlsl_functionality1",
+      "SPV_GOOGLE_user_type",
       "SPV_NV_shader_subgroup_partitioned",
       "SPV_EXT_descriptor_indexing",
       "SPV_EXT_descriptor_heap",
@@ -130,11 +131,13 @@ void LocalSingleStoreElimPass::InitExtensionAllowList() {
       "SPV_NV_mesh_shader",
       "SPV_EXT_mesh_shader",
       "SPV_NV_ray_tracing",
+      "SPV_KHR_ray_tracing",
       "SPV_KHR_ray_query",
       "SPV_EXT_fragment_invocation_density",
       "SPV_EXT_physical_storage_buffer",
       "SPV_KHR_physical_storage_buffer",
       "SPV_KHR_terminate_invocation",
+      "SPV_KHR_shader_clock",
       "SPV_KHR_subgroup_uniform_control_flow",
       "SPV_KHR_integer_dot_product",
       "SPV_EXT_shader_image_int64",
@@ -151,14 +154,14 @@ void LocalSingleStoreElimPass::InitExtensionAllowList() {
       "SPV_KHR_ray_tracing_position_fetch",
       "SPV_AMDX_shader_enqueue",
       "SPV_KHR_fragment_shading_rate",
-      "SPV_KHR_ray_tracing",
       "SPV_KHR_quad_control",
-      "SPV_GOOGLE_user_type",
       "SPV_NV_shader_invocation_reorder",
       "SPV_NV_cluster_acceleration_structure",
       "SPV_NV_linear_swept_spheres",
       "SPV_KHR_maximal_reconvergence",
       "SPV_NV_push_constant_bank",
+      "SPV_EXT_opacity_micromap",
+      "SPV_EXT_shader_invocation_reorder",
   });
 }
 bool LocalSingleStoreElimPass::ProcessVariable(Instruction* var_inst) {