Refactor

Author: Przemog1

include/nbl/builtin/hlsl/emulated/float64_t_impl.hlsl

@@ -78,7 +78,11 @@ NBL_CONSTEXPR_INLINE_FUNC bool isZero(uint64_t val)
     return (val << 1) == 0ull;
 }
 
-inline uint64_t reinterpretAsFloat64BitPattern(uint64_t val)
+template<typename T>
+inline uint64_t reinterpretAsFloat64BitPattern(T);
+
+template<>
+inline uint64_t reinterpretAsFloat64BitPattern<uint64_t>(uint64_t val)
 {
     if (isZero(val))
         return val;
@@ -124,7 +128,8 @@ inline uint64_t reinterpretAsFloat64BitPattern(uint64_t val)
     return biasedExp | mantissa;
 };
 
-inline uint64_t reinterpretAsFloat64BitPattern(int64_t val)
+template<>
+inline uint64_t reinterpretAsFloat64BitPattern<int64_t>(int64_t val)
 {
     const uint64_t sign = val & ieee754::traits<float64_t>::signMask;
     const uint64_t absVal = uint64_t(abs(val));
@@ -167,17 +172,6 @@ NBL_CONSTEXPR_INLINE_FUNC bool operatorLessAndGreaterCommonImplementation(uint64
     {
         if (hlsl::isnan<uint64_t>(lhs) || hlsl::isnan<uint64_t>(rhs))
             return false;
-        if (emulated_float64_t_impl::areBothInfinity(lhs, rhs))
-        {
-            const uint64_t lhsSign = ieee754::extractSignPreserveBitPattern(lhs);
-            const uint64_t rhsSign = ieee754::extractSignPreserveBitPattern(rhs);
-
-            if (lhsSign == rhsSign)
-                return false;
-
-            Op compare;
-            return compare(lhs, rhs);
-        }
         if (emulated_float64_t_impl::areBothZero(lhs, rhs))
             return false;
     }

include/nbl/builtin/hlsl/spirv_intrinsics/glsl.std.450.hlsl

@@ -55,19 +55,19 @@ enable_if_t<is_floating_point_v<FloatingPoint> && !is_matrix_v<FloatingPoint>, F
 
 template<typename FloatingPoint>
 [[vk::ext_instruction(GLSLstd450::GLSLstd450Cross, "GLSL.std.450")]]
-enable_if_t<is_floating_point_v<FloatingPoint>, vector<FloatingPoint, 3> > cross(in vector<FloatingPoint, 3> lhs, in vector<FloatingPoint, 3> rhs);
+enable_if_t<is_floating_point_v<FloatingPoint>, vector<FloatingPoint, 3> > cross(NBL_CONST_REF_ARG(vector<FloatingPoint, 3>) lhs, NBL_CONST_REF_ARG(vector<FloatingPoint, 3>) rhs);
 
 template<typename FloatingPoint>
 [[vk::ext_instruction(GLSLstd450::GLSLstd450FMix, "GLSL.std.450")]]
 enable_if_t<is_floating_point_v<FloatingPoint> && !is_matrix_v<FloatingPoint>, FloatingPoint> fMix(FloatingPoint x, FloatingPoint y, FloatingPoint a);
 
 template<typename T, int N>
 [[vk::ext_instruction(GLSLstd450::GLSLstd450Determinant, "GLSL.std.450")]]
-T determinant(in matrix<T, N, N> mat);
+T determinant(NBL_CONST_REF_ARG(matrix<T, N, N>) mat);
 
 template<typename T, int N>
 [[vk::ext_instruction(GLSLstd450MatrixInverse, "GLSL.std.450")]]
-matrix<T, N, N> matrixInverse(in matrix<T, N, N> mat);
+matrix<T, N, N> matrixInverse(NBL_CONST_REF_ARG(matrix<T, N, N>) mat);
 
 [[vk::ext_instruction(GLSLstd450UnpackSnorm2x16, "GLSL.std.450")]]
 float32_t2 unpackSnorm2x16(uint32_t p);