fixing the memleaks (via not running destructors on IElement derived XML nodes holding smart_refctd_ptr) was a 2 liner!

Author: devshgraphicsprogramming

include/nbl/ext/MitsubaLoader/IElement.h

@@ -30,7 +30,7 @@ template<typename T, typename TypeList>
 using mpl_of_passing_t = mpl_of_passing<T,TypeList>::type;
 }
 
-class IElement
+class IElement : public core::IObjectPoolBase::INonTrivial
 {
 	public:
 		enum class Type

include/nbl/ext/MitsubaLoader/ParserUtil.h

@@ -72,14 +72,13 @@ class ParserManager final
 
 			private:
 				friend class ParserManager;
-				// TODO: This leaks memory all over the place because destructors are not ran!
                 struct PoolConfig
                 {
                     using AddressAllocator = core::LinearAddressAllocator<uint32_t>;
                     using HandleValue = void*;
                     constexpr static inline bool ThreadSafe = false;
                 };
-				using pool_t = core::CMemoryPool<PoolConfig>;
+				using pool_t = core::CObjectPool<PoolConfig>;
 				// could list transform  with supported_elements_t and have a separate pool per type
 				std::unique_ptr<pool_t> objects = std::make_unique<pool_t>(pool_t::creation_params_type{.composed={.addrAllocCtorExtraParams={},.blockSizeKBLog2=12,.initBlockCount=8}});
 		};

src/nbl/ext/MitsubaLoader/CElementIntegrator.cpp

@@ -214,6 +214,7 @@ bool CElementIntegrator::onEndTag(CMitsubaMetadata* metadata, system::logger_opt
 	{
 	}
 
+	// TODO: nested integrators require a deep copy away from the `CObjectPool`
 	/* Nested integrators rely on closing branch to post-order visit here to set the root one as the main one in the metadata
 	if (metadata->m_global.m_integrator.type!=Type::INVALID) // D
 	{