silence a few warnings

Author: devshgraphicsprogramming

include/nbl/builtin/hlsl/math/linalg/basic.hlsl

@@ -42,7 +42,7 @@ MatT identity()
 }
 
 template <uint16_t NOut, uint16_t MOut, uint16_t NIn, uint16_t MIn, typename T NBL_FUNC_REQUIRES(NOut <= NIn && MOut <= MIn && NOut != 0 && MOut != 0)
-inline matrix<T, NOut, MOut> truncate(const NBL_CONST_REF_ARG(matrix<T, NIn, MIn>) inMatrix)
+inline matrix<T, NOut, MOut> truncate(NBL_CONST_REF_ARG(matrix<T, NIn, MIn>) inMatrix)
 {
 	matrix<T, NOut, MOut> retval;
 

src/nbl/ext/MitsubaLoader/CElementBSDF.cpp

@@ -12,6 +12,8 @@
 #include <functional>
 
 
+#pragma warning( push )
+#pragma warning( disable : 5103 )
 namespace nbl::ext::MitsubaLoader
 {
 namespace impl
@@ -422,4 +424,5 @@ bool CElementBSDF::onEndTag(CMitsubaMetadata* globalMetadata, system::logger_opt
 	return true;
 }
 
-}
+}
+#pragma warning( pop )

src/nbl/ext/MitsubaLoader/CElementEmitter.cpp

@@ -21,6 +21,8 @@ auto CElementEmitter::compAddPropertyMap() -> AddPropertyMap<CElementEmitter>
 	using this_t = CElementEmitter;
 	AddPropertyMap<CElementEmitter> retval;
 
+#pragma warning( push )
+#pragma warning( disable : 5103 )
 	// funky transform setting
 	NBL_EXT_MITSUBA_LOADER_REGISTER_ADD_PROPERTY("position",POINT)
 		{
@@ -116,6 +118,7 @@ auto CElementEmitter::compAddPropertyMap() -> AddPropertyMap<CElementEmitter>
 	NBL_EXT_MITSUBA_LOADER_REGISTER_SIMPLE_ADD_VARIANT_PROPERTY_CONSTRAINED(gamma,FLOAT,std::is_same,EnvMap);
 
 #undef ADD_SPECTRUM
+#pragma warning( pop )
 	return retval;
 }
 

src/nbl/ext/MitsubaLoader/CElementIntegrator.cpp

@@ -41,6 +41,8 @@ auto CElementIntegrator::compAddPropertyMap() -> AddPropertyMap<CElementIntegrat
 	using this_t = CElementIntegrator;
 	AddPropertyMap<CElementIntegrator> retval;
 
+#pragma warning( push )
+#pragma warning( disable : 5103 )
 	// common
 	// this one has really funny legacy behaviour which Mitsuba allowed contrary to its PDF docs
 	NBL_EXT_MITSUBA_LOADER_REGISTER_ADD_PROPERTY_CONSTRAINED("shadingSamples",INTEGER,is_any_of,AmbientOcclusion,DirectIllumination)
@@ -200,7 +202,7 @@ auto CElementIntegrator::compAddPropertyMap() -> AddPropertyMap<CElementIntegrat
 
 	// multi channel no extra members
 
-	
+#pragma warning( pop )
 	return retval;
 }
 

src/nbl/ext/MitsubaLoader/CElementSensor.cpp

@@ -15,7 +15,8 @@ auto CElementSensor::compAddPropertyMap() -> AddPropertyMap<CElementSensor>
 {
 	using this_t = CElementSensor;
 	AddPropertyMap<CElementSensor> retval;
-
+#pragma warning( push )
+#pragma warning( disable : 5103 )
 	NBL_EXT_MITSUBA_LOADER_REGISTER_SIMPLE_ADD_VARIANT_PROPERTY_CONSTRAINED(up,VECTOR,derived_from,ShutterSensor);
 	NBL_EXT_MITSUBA_LOADER_REGISTER_SIMPLE_ADD_VARIANT_PROPERTY_CONSTRAINED(shiftX,FLOAT,derived_from,PerspectivePinhole);
 	NBL_EXT_MITSUBA_LOADER_REGISTER_SIMPLE_ADD_VARIANT_PROPERTY_CONSTRAINED(shiftY,FLOAT,derived_from,PerspectivePinhole);
@@ -50,7 +51,7 @@ auto CElementSensor::compAddPropertyMap() -> AddPropertyMap<CElementSensor>
 	NBL_EXT_MITSUBA_LOADER_REGISTER_SIMPLE_ADD_VARIANT_PROPERTY_CONSTRAINED(farClip,FLOAT,derived_from,CameraBase);
 	NBL_EXT_MITSUBA_LOADER_REGISTER_SIMPLE_ADD_VARIANT_PROPERTY_CONSTRAINED(focusDistance,FLOAT,derived_from,DepthOfFieldBase);
 	NBL_EXT_MITSUBA_LOADER_REGISTER_SIMPLE_ADD_VARIANT_PROPERTY_CONSTRAINED(apertureRadius,FLOAT,derived_from,DepthOfFieldBase);
-
+#pragma warning( pop )
 	// special
 	auto setClipPlane = [](this_t* _this, SNamedPropertyElement&& _property, const system::logger_opt_ptr logger)->bool
 	{