Skip to content

Commit 294d22b

Browse files
committed
Always show Examples reporter logs
The reporter job should expose the captured Examples build and install output as dedicated steps for both success and failure paths. Why: The required Examples check should be readable on green runs as well not only when the final status step fails. Why: Separate log steps make the reporter UI match the intended developer workflow and keep the final fail step focused on status only.
1 parent 3650da9 commit 294d22b

1 file changed

Lines changed: 29 additions & 11 deletions

File tree

.github/workflows/build-nabla.yml

Lines changed: 29 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,30 @@ jobs:
464464
name: examples-status-${{ matrix.os }}-${{ matrix.vendor }}-${{ matrix.tag }}-${{ matrix.config }}
465465
path: examples-status
466466

467+
- name: Show Examples build log
468+
if: ${{ always() }}
469+
shell: bash
470+
run: |
471+
log_file="examples-status/build-examples.log"
472+
if [[ ! -f "$log_file" ]]; then
473+
echo "Missing build log"
474+
exit 1
475+
fi
476+
477+
cat "$log_file"
478+
479+
- name: Show Examples install log
480+
if: ${{ always() }}
481+
shell: bash
482+
run: |
483+
log_file="examples-status/install-examples.log"
484+
if [[ ! -f "$log_file" ]]; then
485+
echo "Missing install log"
486+
exit 1
487+
fi
488+
489+
cat "$log_file"
490+
467491
- name: Fail if Examples did not succeed
468492
shell: bash
469493
run: |
@@ -476,18 +500,12 @@ jobs:
476500
result="$(tr -d '\r\n' < "$status_file")"
477501
echo "Examples result: $result"
478502
503+
if [[ -f "examples-status/details.txt" ]]; then
504+
echo "Details:"
505+
cat "examples-status/details.txt"
506+
fi
507+
479508
if [[ "$result" != "success" ]]; then
480-
if [[ -f "examples-status/details.txt" ]]; then
481-
echo "Details:"
482-
cat "examples-status/details.txt"
483-
fi
484-
for file in "examples-status/build-examples.log" "examples-status/install-examples.log"; do
485-
if [[ -f "$file" ]]; then
486-
echo "::group::$(basename "$file")"
487-
cat "$file"
488-
echo "::endgroup::"
489-
fi
490-
done
491509
exit 1
492510
fi
493511

0 commit comments

Comments
 (0)