We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent c545a59 commit 1e907f4Copy full SHA for 1e907f4
1 file changed
src/nbl/ext/MitsubaLoader/PropertyElement.cpp
@@ -257,9 +257,6 @@ std::optional<SNamedPropertyElement> CPropertyElementManager::createPropertyData
257
}
258
up[index] = 1.f;
259
260
- // TODO: after the rm-core matrix PR we need to get rid of the tranpose (I transpose only because of GLM and HLSL mixup)
261
- //const auto lookAtGLM = reinterpret_cast<const hlsl::float32_t4x4&>(glm::lookAtLH<float>(origin,target,up));
262
- //const auto lookAt = hlsl::transpose(lookAtGLM);
263
const auto lookAt = hlsl::math::linalg::rhLookAt(origin, target, up);
264
// mitsuba understands look-at and right-handed camera little bit differently than I do
265
const auto rotation = hlsl::inverse(hlsl::float32_t3x3(lookAt));
0 commit comments