Handles SpirvIntrinsicInstruction barriers in CapabilityVisitor. (microsoft#7711)

Fixes microsoft#7671.

Author: danbrown-amd

tools/clang/lib/SPIRV/CapabilityVisitor.cpp

@@ -615,9 +615,13 @@ bool CapabilityVisitor::visitInstruction(SpirvInstruction *instr) {
   }
   case spv::Op::OpControlBarrier:
   case spv::Op::OpMemoryBarrier: {
-    auto barrier = cast<SpirvBarrier>(instr);
-    if ((bool)(barrier->getMemorySemantics() &
-               spv::MemorySemanticsMask::OutputMemoryKHR)) {
+    auto barrier = dyn_cast<SpirvBarrier>(instr);
+    // barrier will be null if the instruction was generated from inline spir-v.
+    // In that case, it is the user's responsibility to ensure the correct
+    // capabilities are added.
+    if (barrier && (barrier->getMemorySemantics() &
+                    spv::MemorySemanticsMask::OutputMemoryKHR) ==
+                       spv::MemorySemanticsMask::OutputMemoryKHR) {
       featureManager.requestTargetEnv(SPV_ENV_VULKAN_1_3, "NODE_OUTPUT_MEMORY",
                                       loc);
       addCapability(spv::Capability::VulkanMemoryModel, loc);

tools/clang/test/CodeGenSPIRV/node.barrier.spirv-intrinsic.hlsl

@@ -0,0 +1,22 @@
+// RUN: %dxc -T lib_6_8 -spirv -fspv-target-env=vulkan1.3 -HV 202x -fvk-use-scalar-layout -E main %s | FileCheck %s
+
+#define MemorySemanticsAcquireReleaseMask 0x00000008
+#define MemorySemanticsWorkgroupMemoryMask 0x00000100
+#define ScopeWorkgroup 2
+#define OpControlBarrier 224
+
+[[vk::ext_instruction( OpControlBarrier )]]
+void controlBarrier(uint32_t executionScope, uint32_t memoryScope, uint32_t memorySemantics);
+
+[numthreads(64,1,1)]
+[shader("compute")]
+void main(uint32_t3 ID : SV_DispatchThreadID)
+{
+  controlBarrier(ScopeWorkgroup, ScopeWorkgroup, MemorySemanticsAcquireReleaseMask | MemorySemanticsWorkgroupMemoryMask);
+}
+
+// CHECK: [[UINT:%[^ ]*]] = OpTypeInt 32 0
+// CHECK-DAG: [[U2:%[^ ]*]] = OpConstant [[UINT]] 2
+// CHECK-DAG: [[U264:%[^ ]*]] = OpConstant [[UINT]] 264
+// CHECK: OpControlBarrier [[U2]] [[U2]] [[U264]]
+