Merge pull request #267 from Cysharp/hadashiA/remove-default-value

Remove default value detection

Author: hadashiA

src/MemoryPack.Generator/MemoryPackGenerator.Emitter.cs

@@ -1,8 +1,6 @@
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
-using System;
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.Text;
 
@@ -46,7 +44,7 @@ static void Generate(TypeDeclarationSyntax syntax, Compilation compilation, stri
         }
         var unionFormatter = (unionSymbol != null);
 
-        var typeMeta = new TypeMeta(semanticModel, typeSymbol, reference);
+        var typeMeta = new TypeMeta(typeSymbol, reference);
         if (unionFormatter)
         {
             // replace original symbol
@@ -516,7 +514,7 @@ private string EmitDeserializeBody()
         {
             {{(IsValueType ? "" : "if (value == null)")}}
             {
-{{Members.Where(x => x.Symbol != null).Select(x => $"               __{x.Name} = {x.DefaultValueExpression};").NewLine()}}
+{{Members.Where(x => x.Symbol != null).Select(x => $"               __{x.Name} = default!;").NewLine()}}
             }
 {{(IsValueType ? "#if false" : "            else")}}
             {
@@ -1366,75 +1364,4 @@ public string EmitReadRefDeserialize(int i, bool requireDeltaCheck)
                 return $"{pre}reader.ReadValue(ref __{Name});";
         }
     }
-
-    string EmitConstantValue(object? constantValue)
-    {
-        if (constantValue != null)
-        {
-            return constantValue switch
-            {
-                string x => $"\"{x}\"",
-                char x => $"'{x}'",
-                float x => $"{x}f",
-                decimal x => $"{x}M",
-                bool x => x ? "true" : "false",
-                _ => constantValue.ToString()
-            };
-        }
-        return "default!";
-    }
-
-    string EmitExpression(ExpressionSyntax expression)
-    {
-        switch (expression.Kind())
-        {
-            case SyntaxKind.SimpleMemberAccessExpression:
-            {
-                var memberAccess = (MemberAccessExpressionSyntax)expression;
-                var memberSymbol = semanticModel.GetSymbolInfo(memberAccess.Name).Symbol;
-                if (memberSymbol is INamedTypeSymbol { TypeKind: TypeKind.Enum } namedTypeSymbol)
-                {
-                    return $"{GetTypeFullName(namedTypeSymbol)}.{memberAccess.Name}";
-                }
-                if (memberSymbol is IFieldSymbol { Type.TypeKind: TypeKind.Enum } fieldSymbol)
-                {
-                    return $"{GetTypeFullName(fieldSymbol.Type)}.{fieldSymbol.Name}";
-                }
-                break;
-            }
-
-            case SyntaxKind.ObjectCreationExpression:
-            {
-                var objectCreation = (ObjectCreationExpressionSyntax)expression;
-                var symbolInfo = semanticModel.GetSymbolInfo(objectCreation.Type);
-                if (symbolInfo.Symbol is INamedTypeSymbol x)
-                {
-                    var arguments = string.Join(", ",
-                        objectCreation.ArgumentList?.Arguments.Select(arg =>
-                            EmitExpression(arg.Expression)) ?? Enumerable.Empty<string>());
-                    return $"new {GetTypeFullName(x)}({arguments})";
-                }
-                break;
-            }
-
-            case SyntaxKind.TupleExpression:
-                var tupleExpression = (TupleExpressionSyntax)expression;
-                var tupleElements = string.Join(", ",
-                    tupleExpression.Arguments.Select(arg => EmitExpression(arg.Expression)));
-                return $"({tupleElements})";
-        }
-        return expression.ToString();
-    }
-
-    static string GetTypeFullName(ITypeSymbol typeSymbol)
-    {
-        if (typeSymbol.ContainingType is { } containingType)
-        {
-            // nested type
-            var containingTypeFullName = containingType.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat);
-            var typeName = typeSymbol.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat);
-            return $"{containingTypeFullName}.{typeName}";
-        }
-        return typeSymbol.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat);
-    }
 }

src/MemoryPack.Generator/MemoryPackGenerator.Parser.cs

@@ -66,7 +66,7 @@ public partial class TypeMeta
     public (ushort Tag, INamedTypeSymbol Type)[] UnionTags { get; }
     public bool IsUseEmptyConstructor => Constructor == null || Constructor.Parameters.IsEmpty;
 
-    public TypeMeta(SemanticModel semanticModel, INamedTypeSymbol symbol, ReferenceSymbols reference)
+    public TypeMeta(INamedTypeSymbol symbol, ReferenceSymbols reference)
     {
         this.reference = reference;
         this.Symbol = symbol;
@@ -104,7 +104,7 @@ public TypeMeta(SemanticModel semanticModel, INamedTypeSymbol symbol, ReferenceS
                 }
                 return true;
             })
-            .Select((x, i) => new MemberMeta(semanticModel, x, Constructor, reference, i))
+            .Select((x, i) => new MemberMeta(x, Constructor, reference, i))
             .OrderBy(x => x.Order)
             .ToArray();
 
@@ -615,8 +615,6 @@ partial class MemberMeta
     public int Order { get; }
     public bool HasExplicitOrder { get; }
     public MemberKind Kind { get; }
-    public string DefaultValueExpression { get; } = "default!";
-    readonly SemanticModel semanticModel;
 
     MemberMeta(int order)
     {
@@ -627,9 +625,8 @@ partial class MemberMeta
         this.Kind = MemberKind.Blank;
     }
 
-    public MemberMeta(SemanticModel semanticModel, ISymbol symbol, IMethodSymbol? constructor, ReferenceSymbols references, int sequentialOrder)
+    public MemberMeta(ISymbol symbol, IMethodSymbol? constructor, ReferenceSymbols references, int sequentialOrder)
     {
-        this.semanticModel = semanticModel;
         this.Symbol = symbol;
         this.Name = symbol.Name;
         this.Order = sequentialOrder;
@@ -649,10 +646,6 @@ public MemberMeta(SemanticModel semanticModel, ISymbol symbol, IMethodSymbol? co
         {
             this.IsConstructorParameter = constructor.TryGetConstructorParameter(symbol, out var constructorParameter);
             this.ConstructorParameterName = constructorParameter?.Name;
-            if (constructorParameter?.HasExplicitDefaultValue == true)
-            {
-                DefaultValueExpression = EmitConstantValue(constructorParameter.ExplicitDefaultValue);
-            }
         }
         else
         {
@@ -670,25 +663,6 @@ public MemberMeta(SemanticModel semanticModel, ISymbol symbol, IMethodSymbol? co
 #endif
                 ;
             MemberType = f.Type;
-
-            // Detect default value
-            foreach (var syntaxReference in f.DeclaringSyntaxReferences)
-            {
-                var syntax = syntaxReference.GetSyntax();
-                if (syntax is FieldDeclarationSyntax { Declaration.Variables: { Count: > 0 } variables })
-                {
-                    if (variables.First().Initializer is { } initializer)
-                    {
-                        DefaultValueExpression = EmitExpression(initializer.Value);
-                        break;
-                    }
-                }
-                if (syntax is VariableDeclaratorSyntax  { Initializer: { } initializer2 })
-                {
-                    DefaultValueExpression = EmitExpression(initializer2.Value);
-                    break;
-                }
-            }
         }
         else if (symbol is IPropertySymbol p)
         {
@@ -701,16 +675,6 @@ public MemberMeta(SemanticModel semanticModel, ISymbol symbol, IMethodSymbol? co
 #endif
                 && (p.SetMethod != null && !p.SetMethod.IsInitOnly);
             MemberType = p.Type;
-
-            // Detect default value
-            foreach (var syntaxReference in p.DeclaringSyntaxReferences)
-            {
-                if (syntaxReference.GetSyntax() is PropertyDeclarationSyntax { Initializer: { } initializer })
-                {
-                    DefaultValueExpression = EmitExpression(initializer.Value);
-                    break;
-                }
-            }
         }
         else
         {

src/MemoryPack.Generator/MemoryPackGenerator.TypeScript.cs

@@ -38,7 +38,7 @@ partial class MemoryPackGenerator
             return null;
         }
 
-        var typeMeta = new TypeMeta(semanticModel, typeSymbol, reference);
+        var typeMeta = new TypeMeta(typeSymbol, reference);
 
         if (typeMeta.GenerateType is not (GenerateType.Object or GenerateType.Union))
         {