Fix warnings

Author: hadashiA

sandbox/SandboxConsoleApp/SandboxConsoleApp.csproj

@@ -6,7 +6,7 @@
         <ImplicitUsings>disable</ImplicitUsings>
         <Nullable>enable</Nullable>
         <IsPackable>false</IsPackable>
-        <PublishAot>true</PublishAot>
+        <!-- <PublishAot>true</PublishAot> -->
     </PropertyGroup>
 
     <ItemGroup>

src/MemoryPack.Core/Compression/BrotliCompressor.cs

@@ -132,12 +132,12 @@ public void CopyTo<TBufferWriter>(in TBufferWriter destBufferWriter)
             var writtenNotAdvanced = 0;
             foreach (var item in bufferWriter)
             {
-                writtenNotAdvanced = CompressCore(ref encoder, item.Span, ref Unsafe.AsRef(destBufferWriter), initialLength: null, isFinalBlock: false);
+                writtenNotAdvanced = CompressCore(ref encoder, item.Span, ref Unsafe.AsRef(in destBufferWriter), initialLength: null, isFinalBlock: false);
             }
 
             // call BrotliEncoderOperation.Finish
             var finalBlockLength = (writtenNotAdvanced == 0) ? null : (int?)(writtenNotAdvanced + 10);
-            CompressCore(ref encoder, ReadOnlySpan<byte>.Empty, ref Unsafe.AsRef(destBufferWriter), initialLength: finalBlockLength, isFinalBlock: true);
+            CompressCore(ref encoder, ReadOnlySpan<byte>.Empty, ref Unsafe.AsRef(in destBufferWriter), initialLength: finalBlockLength, isFinalBlock: true);
         }
         finally
         {

src/MemoryPack.Core/Formatters/MemoryPackableFormatter.cs

@@ -12,7 +12,7 @@ public sealed class MemoryPackableFormatter<T> : MemoryPackFormatter<T>
     [Preserve]
     public override void Serialize<TBufferWriter>(ref MemoryPackWriter<TBufferWriter> writer, scoped ref T? value)
     {
-        T.Serialize(ref writer, ref Unsafe.AsRef(value));
+        T.Serialize(ref writer, ref Unsafe.AsRef(in value));
     }
 
     [Preserve]

src/MemoryPack.Core/MemoryPackSerializer.NonGenerics.cs

@@ -47,7 +47,7 @@ public static unsafe void Serialize<TBufferWriter>(Type type, in TBufferWriter b
 
         try
         {
-            var writer = new MemoryPackWriter<TBufferWriter>(ref Unsafe.AsRef(bufferWriter), state);
+            var writer = new MemoryPackWriter<TBufferWriter>(ref Unsafe.AsRef(in bufferWriter), state);
             Serialize(type, ref writer, value);
         }
         finally

src/MemoryPack.Core/MemoryPackSerializer.Serialize.cs

@@ -141,7 +141,7 @@ public static unsafe void Serialize<T, TBufferWriter>(in TBufferWriter bufferWri
 
         try
         {
-            var writer = new MemoryPackWriter<TBufferWriter>(ref Unsafe.AsRef(bufferWriter), state);
+            var writer = new MemoryPackWriter<TBufferWriter>(ref Unsafe.AsRef(in bufferWriter), state);
             Serialize(ref writer, value);
         }
         finally

src/MemoryPack.Core/MemoryPackWriter.cs

@@ -306,7 +306,7 @@ public void WriteUtf16(string? value)
         Unsafe.WriteUnaligned(ref dest, value.Length);
 
 #if NET7_0_OR_GREATER
-        ref var src = ref Unsafe.As<char, byte>(ref Unsafe.AsRef(value.GetPinnableReference()));
+        ref var src = ref Unsafe.As<char, byte>(ref Unsafe.AsRef(in value.GetPinnableReference()));
         Unsafe.CopyBlockUnaligned(ref Unsafe.Add(ref dest, 4), ref src, (uint)copyByteCount);
 #else
         MemoryMarshal.AsBytes(value.AsSpan()).CopyTo(MemoryMarshal.CreateSpan(ref Unsafe.Add(ref dest, 4), copyByteCount));
@@ -405,7 +405,7 @@ public void WritePackable<T>(scoped in T? value)
     {
         depth++;
         if (depth == DepthLimit) MemoryPackSerializationException.ThrowReachedDepthLimit(typeof(T));
-        T.Serialize(ref this, ref Unsafe.AsRef(value));
+        T.Serialize(ref this, ref Unsafe.AsRef(in value));
         depth--;
     }
 
@@ -426,7 +426,7 @@ public void WriteValue<T>(scoped in T? value)
     {
         depth++;
         if (depth == DepthLimit) MemoryPackSerializationException.ThrowReachedDepthLimit(typeof(T));
-        GetFormatter<T>().Serialize(ref this, ref Unsafe.AsRef(value));
+        GetFormatter<T>().Serialize(ref this, ref Unsafe.AsRef(in value));
         depth--;
     }
 
@@ -444,7 +444,7 @@ public void WriteValueWithFormatter<TFormatter, T>(TFormatter formatter, scoped
         where TFormatter : IMemoryPackFormatter<T>
     {
         depth++;
-        formatter.Serialize(ref this, ref Unsafe.AsRef(value));
+        formatter.Serialize(ref this, ref Unsafe.AsRef(in value));
         depth--;
     }
 
@@ -503,7 +503,7 @@ public void WriteSpan<T>(scoped ReadOnlySpan<T?> value)
         WriteCollectionHeader(value.Length);
         for (int i = 0; i < value.Length; i++)
         {
-            formatter.Serialize(ref this, ref Unsafe.AsRef(value[i]));
+            formatter.Serialize(ref this, ref Unsafe.AsRef(in value[i]));
         }
     }
 
@@ -575,7 +575,7 @@ public void WritePackableSpan<T>(scoped ReadOnlySpan<T?> value)
         WriteCollectionHeader(value.Length);
         for (int i = 0; i < value.Length; i++)
         {
-            T.Serialize(ref this, ref Unsafe.AsRef(value[i]));
+            T.Serialize(ref this, ref Unsafe.AsRef(in value[i]));
         }
 #endif
     }
@@ -697,7 +697,7 @@ public void WriteSpanWithoutLengthHeader<T>(scoped ReadOnlySpan<T?> value)
             var formatter = GetFormatter<T>();
             for (int i = 0; i < value.Length; i++)
             {
-                formatter.Serialize(ref this, ref Unsafe.AsRef(value[i]));
+                formatter.Serialize(ref this, ref Unsafe.AsRef(in value[i]));
             }
         }
     }