Clarify semantics of ObfuscationAttribute marking

If a pattern exists: it will be evaluated at the members indivdually if ApplyToMember.
If a pattern does not exist: it will apply at the item and the members would inherit them if ApplyToMember.

Author: yck1509

Confuser.Core/ObfAttrMarker.cs

@@ -38,6 +38,12 @@ class ProtectionSettingsStack {
 			readonly ObfAttrParser parser;
 			ProtectionSettings settings;
 
+			enum ApplyInfoType {
+				CurrentInfoOnly,
+				CurrentInfoInherits,
+				ParentInfo
+			}
+
 			class PopHolder : IDisposable {
 				ProtectionSettingsStack parent;
 
@@ -76,21 +82,20 @@ public IDisposable Apply(IDnlibDef target, IEnumerable<ProtectionSettingsInfo> i
 				var infoArray = infos.ToArray();
 
 				if (stack.Count > 0) {
-					foreach (var i in stack.Skip(1).Reverse())
-						ApplyInfo(target, settings, i.Item2.Where(info => info.Condition != null), false);
-					ApplyInfo(target, settings, stack.Peek().Item2, false);
+					foreach (var i in stack.Reverse())
+						ApplyInfo(target, settings, i.Item2, ApplyInfoType.ParentInfo);
 				}
 
 				IDisposable result;
 				if (infoArray.Length != 0) {
 					var originalSettings = this.settings;
 
 					// the settings that would apply to members
-					ApplyInfo(target, settings, infoArray, false);
+					ApplyInfo(target, settings, infoArray, ApplyInfoType.CurrentInfoInherits);
 					this.settings = new ProtectionSettings(settings);
 
 					// the settings that would apply to itself
-					ApplyInfo(target, settings, infoArray, true);
+					ApplyInfo(target, settings, infoArray, ApplyInfoType.CurrentInfoOnly);
 					stack.Push(Tuple.Create(originalSettings, infoArray));
 
 					result = new PopHolder(this);
@@ -102,21 +107,23 @@ public IDisposable Apply(IDnlibDef target, IEnumerable<ProtectionSettingsInfo> i
 				return result;
 			}
 
-			void ApplyInfo(IDnlibDef context, ProtectionSettings settings, IEnumerable<ProtectionSettingsInfo> infos, bool current) {
+			void ApplyInfo(IDnlibDef context, ProtectionSettings settings, IEnumerable<ProtectionSettingsInfo> infos, ApplyInfoType type) {
 				foreach (var info in infos) {
 					if (info.Condition != null && !(bool)info.Condition.Evaluate(context))
 						continue;
 
-					if (info.Exclude) {
-						if (current)
-							settings.Clear();
-						else if (info.ApplyToMember)
+					if (info.Condition == null && info.Exclude) {
+						if (type == ApplyInfoType.CurrentInfoOnly ||
+							(type == ApplyInfoType.CurrentInfoInherits && info.ApplyToMember)) {
 							settings.Clear();
-						continue;
+						}
 					}
-
-					if ((info.ApplyToMember || current || info.Condition != null) && !string.IsNullOrEmpty(info.Settings)) {
-						parser.ParseProtectionString(settings, info.Settings);
+					if (!string.IsNullOrEmpty(info.Settings)) {
+						if ((type == ApplyInfoType.ParentInfo && info.Condition != null && info.ApplyToMember) ||
+							type == ApplyInfoType.CurrentInfoOnly ||
+							(type == ApplyInfoType.CurrentInfoInherits && info.Condition == null && info.ApplyToMember)) {
+							parser.ParseProtectionString(settings, info.Settings);
+						}
 					}
 				}
 			}
@@ -232,7 +239,7 @@ ProtectionSettingsInfo ToInfo(Rule rule, PatternExpression expr) {
 			info.Condition = expr;
 
 			info.Exclude = false;
-			info.ApplyToMember = false;
+			info.ApplyToMember = true;
 
 			var settings = new StringBuilder();
 			foreach (var item in rule) {