CmakeRunner is not working with overseer. overseer.strategy.toggelterm not found in LazyVim

[basava70]

Hi,
thanks for the awesome plugin. It saved me a lot of time.
However, I ran into an issue when I tried to change the cmake_runner to overseer.
The runner is working perfectly fine, if it is "terminal" or "toggelterm". I only have issues with "overseer".

return {
  "Civitasv/cmake-tools.nvim",
  dependencies = { "akinsho/toggleterm.nvim" },
  ft = { "c", "cpp", "cuda", "objc", "objcpp", "cmake" },
  opts = {
    cmake_runner = {
      name = "overseer",
      opts = {},
    },
  },
}

this is my file.

	no field package.preload['overseer.strategy.terminal']
	cache_loader: module 'overseer.strategy.terminal' not found
	cache_loader_lib: module 'overseer.strategy.terminal' not found
	no file './overseer/strategy/terminal.lua'
	no file '/usr/share/luajit-2.1/overseer/strategy/terminal.lua'
	no file '/usr/local/share/lua/5.1/overseer/strategy/terminal.lua'
	no file '/usr/local/share/lua/5.1/overseer/strategy/terminal/init.lua'
	no file '/usr/share/lua/5.1/overseer/strategy/terminal.lua'
	no file '/usr/share/lua/5.1/overseer/strategy/terminal/init.lua'

Any help would be nice.
Thanks in advance.

[narodo]

I just ran into the same issue.
The problem seems to be that overseer 2.0 (see this PR) introduced breaking changes. The "terminal" strategy does not exist anymore.
Unfortunately the terminal strategy is set as default in the const.lua file and can't be overwritten since the API only extends this table. At least I didn't find a way.

I came up with this workaround that uses the jobstart strategy instead.

        cmake_executor = {
            name = "overseer",
            default_opts = {
                overseer = {
                    new_task_opts = {
                        strategy = {
                            "jobstart",
                            use_terminal = false,
                            perserve_output = false,
                        },
                    },
                    -- if you don't want the overseer task list to open overwritting this
                    -- function helps. Otherwise just remove this section
                    on_new_task = function(task)
                        -- require("overseer").open({ enter = false, direction = "right" })
                    end,
                }
            },
        }

[lceWolf]

I am not familiar with overseer. Any idea what the proper replacement for the removed "terminal" strategy is? Is it "jobstart"?

[narodo]

I am not too familiar either to be honest.
But my understanding is that the default is still "terminal" (see Overseer doc) but you can't explicitly specify it anymore as a strategy.

I just tried again, and it also works if you set the strategy to nil, rather than jobstart.

This works (I assume it picks the terminal strategy as default):

local task = require("overseer").new_task({
    cmd = { "ls" },
    strategy = nil,
    components = { { "on_output_quickfix", open = true }, "default" }
})

But passing in an empty strategy fails:

local task = require("overseer").new_task({
    cmd = { "ls" },
    strategy = {},
    components = { { "on_output_quickfix", open = true }, "default" }
})

Error executing Lua callback: ...e/nvim/lazy/overseer.nvim/lua/overseer/strategy/init.lua:18: module 'overseer.strategy.nil' not found

But setting it to 'nil' in the cmake_executor does not work.
I assume this has to do with the override logic?

[lceWolf]

mind checking #358 ? looks like overseer sets sensible defaults for the strategy and uses "jobstart".

You are indeed correct. Setting it to nil in "user code" does not work as it can not remove the key from the defaults due to how the merging works.