Skip to content

Commit b2a684b

Browse files
author
indieisaconcept
committed
Added CDATA wrapper to evidence output for JUNIT formatter
1 parent a123413 commit b2a684b

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/formatters/junit-xml.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ CSSLint.addFormatter({
8585
// build the test case seperately, once joined
8686
// we'll add it to a custom array filtered by type
8787
output.push("<testcase time=\"0\" name=\"" + generateSource(message.rule) + "\">");
88-
output.push("<" + type + " message=\"" + escapeSpecialCharacters(message.message) + "\">" + message.line + ':' + message.col + ':' + escapeSpecialCharacters(message.evidence) + "</" + type + ">");
88+
output.push("<" + type + " message=\"" + escapeSpecialCharacters(message.message) + "\"><![CDATA[" + message.line + ':' + message.col + ':' + escapeSpecialCharacters(message.evidence) + "]]></" + type + ">");
8989
output.push("</testcase>");
9090

9191
tests[type] += 1;

tests/formatters/junit-xml.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
], stats: [] },
2424

2525
file = "<testsuite time=\"0\" tests=\"2\" skipped=\"0\" errors=\"2\" failures=\"0\" package=\"net.csslint\" name=\"FILE\">",
26-
error1 = "<testcase time=\"0\" name=\"net.csslint.ARule\"><error message=\"BOGUS\">1:1:ALSO BOGUS</error></testcase>",
27-
error2 = "<testcase time=\"0\" name=\"net.csslint.SomeOtherRule\"><error message=\"BOGUS\">2:1:ALSO BOGUS</error></testcase>",
26+
error1 = "<testcase time=\"0\" name=\"net.csslint.ARule\"><error message=\"BOGUS\"><![CDATA[1:1:ALSO BOGUS]]></error></testcase>",
27+
error2 = "<testcase time=\"0\" name=\"net.csslint.SomeOtherRule\"><error message=\"BOGUS\"><![CDATA[2:1:ALSO BOGUS]]></error></testcase>",
2828
expected = "<?xml version=\"1.0\" encoding=\"utf-8\"?><testsuites>" + file + error1 + error2 + "</testsuite></testsuites>",
2929
actual = CSSLint.format(result, "FILE", "junit-xml");
3030

@@ -41,8 +41,8 @@
4141
], stats: [] },
4242

4343
file = "<testsuite time=\"0\" tests=\"2\" skipped=\"0\" errors=\"2\" failures=\"0\" package=\"net.csslint\" name=\"FILE\">",
44-
error1 = "<testcase time=\"0\" name=\"\"><error message=\"sneaky, 'sneaky', &lt;sneaky&gt;\">1:1:ALSO BOGUS</error></testcase>",
45-
error2 = "<testcase time=\"0\" name=\"\"><error message=\"sneaky, 'sneaky', &lt;sneaky&gt;\">2:1:ALSO BOGUS</error></testcase>",
44+
error1 = "<testcase time=\"0\" name=\"\"><error message=\"sneaky, 'sneaky', &lt;sneaky&gt;\"><![CDATA[1:1:ALSO BOGUS]]></error></testcase>",
45+
error2 = "<testcase time=\"0\" name=\"\"><error message=\"sneaky, 'sneaky', &lt;sneaky&gt;\"><![CDATA[2:1:ALSO BOGUS]]></error></testcase>",
4646
expected = "<?xml version=\"1.0\" encoding=\"utf-8\"?><testsuites>" + file + error1 + error2 + "</testsuite></testsuites>",
4747
actual = CSSLint.format(result, "FILE", "junit-xml");
4848

0 commit comments

Comments
 (0)