Autoconfigure network without DHCP

Passt includes a DHCP server to allow guests to easily configure the
network without being aware passt is on the other side. But we _are_
aware of that, so we can take advantage of it.

Instead of using DHCP, read the configuration output from passt,
marshall it into some environment variables, pass it to the guest, and
have krun-guest read it and apply it using rtnetlink.

By doing that, we reduce the startup time in half, from...

$ time krun /bin/false
(...)
real    0m4,301s

... to ...

$ time krun /bin/false
(...)
real    0m1,966s

Signed-off-by: Sergio Lopez <[email protected]>

Author: slp

Cargo.lock

@@ -13,10 +13,13 @@ anyhow = { version = "1.0.82", default-features = false, features = ["std"] }
 bpaf = { version = "0.9.11", default-features = false, features = [] }
 byteorder = { version = "1.5.0", default-features = false, features = ["std"] }
 env_logger = { version = "0.11.3", default-features = false, features = ["auto-color", "humantime", "unstable-kv"] }
+futures-util = "0.3.30"
 krun-sys = { path = "../krun-sys", version = "1.9.1", default-features = false, features = [] }
 log = { version = "0.4.21", default-features = false, features = ["kv"] }
 nix = { version = "0.28.0", default-features = false, features = ["user"] }
+regex = { version = "1.10.6" }
 rustix = { version = "0.38.34", default-features = false, features = ["fs", "mount", "process", "std", "system", "use-libc-auxv"] }
+rtnetlink = { version = "0.14.1" }
 serde = { version = "1.0.203", default-features = false, features = ["derive"] }
 serde_json = { version = "1.0.117", default-features = false, features = ["std"] }
 tempfile = { version = "3.10.1", default-features = false, features = [] }

crates/krun/Cargo.toml

@@ -187,13 +187,19 @@ fn main() -> Result<()> {
         }
     }
 
+    let mut env = prepare_env_vars(env).context("Failed to prepare environment variables")?;
+    env.insert(
+        "KRUN_SERVER_PORT".to_owned(),
+        options.server_port.to_string(),
+    );
+
     {
         let passt_fd: OwnedFd = if let Some(passt_socket) = options.passt_socket {
             connect_to_passt(passt_socket)
                 .context("Failed to connect to `passt`")?
                 .into()
         } else {
-            start_passt(options.server_port)
+            start_passt(options.server_port, &mut env)
                 .context("Failed to start `passt`")?
                 .into()
         };
@@ -330,11 +336,6 @@ fn main() -> Result<()> {
         vec
     };
 
-    let mut env = prepare_env_vars(env).context("Failed to prepare environment variables")?;
-    env.insert(
-        "KRUN_SERVER_PORT".to_owned(),
-        options.server_port.to_string(),
-    );
     let env: Vec<CString> = {
         let mut vec = Vec::with_capacity(env.len());
         for (key, value) in env {

crates/krun/src/bin/krun.rs

@@ -42,7 +42,12 @@ fn main() -> Result<()> {
 
     setup_fex()?;
 
-    configure_network()?;
+    let rt = tokio::runtime::Runtime::new().unwrap();
+    rt.block_on(async {
+        if let Err(err) = configure_network().await {
+            eprintln!("Failed to configure network, continuing without it: {err}");
+        }
+    });
 
     if let Some(hidpipe_client_path) = find_in_path("hidpipe-client")? {
         Command::new(hidpipe_client_path)