Skip to content

Commit e263e6d

Browse files
committed
clippy: replace is_err and is_some with if let
Clippy now complains about unnecessary wraps, so lets avoid them. Signed-off-by: Sergio Lopez <[email protected]>
1 parent e908ef5 commit e263e6d

3 files changed

Lines changed: 10 additions & 27 deletions

File tree

crates/muvm/src/guest/bridge/common.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -982,11 +982,8 @@ pub fn bridge_loop<T: ProtocolHandler>(sock_path: &str) {
982982
let events = evt.events();
983983
if fd == listen_sock.as_raw_fd() as u64 {
984984
let res = listen_sock.accept();
985-
if res.is_err() {
986-
eprintln!(
987-
"Failed to accept a connection, error: {:?}",
988-
res.unwrap_err()
989-
);
985+
if let Err(res) = res {
986+
eprintln!("Failed to accept a connection, error: {res:?}");
990987
continue;
991988
}
992989
let stream = res.unwrap().0;

crates/muvm/src/guest/server_worker.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -373,11 +373,8 @@ fn run_io_guest(
373373
let mut vsock = StdUnixStream::from(vsock_fd);
374374
let epoll = Epoll::new(EpollCreateFlags::empty())?;
375375
epoll.add(&stdout, EpollEvent::new(EpollFlags::EPOLLIN, 1))?;
376-
if stderr.is_some() {
377-
epoll.add(
378-
stderr.as_ref().unwrap(),
379-
EpollEvent::new(EpollFlags::EPOLLIN, 2),
380-
)?;
376+
if let Some(ref stderr) = stderr {
377+
epoll.add(stderr, EpollEvent::new(EpollFlags::EPOLLIN, 2))?;
381378
}
382379
epoll.add(&vsock, EpollEvent::new(EpollFlags::EPOLLIN, 3))?;
383380
epoll.add(&stop_pipe, EpollEvent::new(EpollFlags::EPOLLIN, 4))?;

crates/muvm/src/hidpipe_server.rs

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -257,12 +257,8 @@ where
257257
return true;
258258
}
259259
let res = f(v);
260-
if res.is_err() {
261-
error!(
262-
"Client {} disconnected with error: {:?}",
263-
*k,
264-
res.unwrap_err()
265-
);
260+
if let Err(res) = res {
261+
error!("Client {} disconnected with error: {:?}", *k, res,);
266262
epoll.delete(&v.socket).unwrap();
267263
false
268264
} else {
@@ -277,12 +273,8 @@ where
277273
{
278274
let client = clients.get_mut(&fd).unwrap();
279275
let res = f(client);
280-
if res.is_err() {
281-
error!(
282-
"Client {} disconnected with error: {:?}",
283-
fd,
284-
res.unwrap_err()
285-
);
276+
if let Err(res) = res {
277+
error!("Client {} disconnected with error: {:?}", fd, res,);
286278
epoll.delete(&client.socket).unwrap();
287279
clients.remove(&fd);
288280
}
@@ -400,11 +392,8 @@ fn run(mut evdevs: EvdevContainer, listen_sock: UnixListener, epoll: Epoll) {
400392
}
401393
} else if fd == listen_sock.as_raw_fd() as u64 {
402394
let res = listen_sock.accept();
403-
if res.is_err() {
404-
error!(
405-
"Failed to accept a connection, error: {:?}",
406-
res.unwrap_err()
407-
);
395+
if let Err(res) = res {
396+
error!("Failed to accept a connection, error: {:?}", res,);
408397
continue;
409398
}
410399
let stream = res.unwrap().0;

0 commit comments

Comments
 (0)