Skip to content

Commit d937acb

Browse files
slphoshinolina
authored andcommitted
Remove x11bridge feature gate
Make x11bridge a non-optional component of muvm, in preparation of making it the default way to proxy graphical apps from the guest to the host. Signed-off-by: Sergio Lopez <[email protected]>
1 parent a04c1ba commit d937acb

4 files changed

Lines changed: 1 addition & 17 deletions

File tree

crates/muvm/src/bin/muvm.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,6 @@ fn main() -> Result<()> {
421421
);
422422
env.insert("MUVM_SERVER_COOKIE".to_owned(), cookie.to_string());
423423

424-
#[cfg(feature = "x11bridge")]
425424
if options.direct_x11 {
426425
let display =
427426
env::var("DISPLAY").context("X11 forwarding requested but DISPLAY is unset")?;

crates/muvm/src/cli_options.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -109,14 +109,6 @@ pub fn options() -> OptionParser<Options> {
109109
.short('x')
110110
.help("Use direct X11 forwarding instead of sommelier + XWayland")
111111
.switch();
112-
113-
#[cfg(not(feature = "x11bridge"))]
114-
let direct_x11 = direct_x11
115-
.guard(
116-
|x| !*x,
117-
"--direct-x11 requires the `x11bridge` crate feature",
118-
)
119-
.hide();
120112
let interactive = long("interactive")
121113
.short('i')
122114
.help("Allocate a tty guest-side and connect it to the current stdin/out")

crates/muvm/src/guest/bin/muvm-guest.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ use muvm::guest::net::configure_network;
1313
use muvm::guest::socket::setup_socket_proxy;
1414
use muvm::guest::sommelier::exec_sommelier;
1515
use muvm::guest::user::setup_user;
16-
#[cfg(feature = "x11bridge")]
1716
use muvm::guest::x11::setup_x11_forwarding;
1817
use rustix::process::{getrlimit, setrlimit, Resource};
1918

@@ -81,12 +80,7 @@ fn main() -> Result<()> {
8180
let pulse_path = pulse_path.join("native");
8281
setup_socket_proxy(pulse_path, 3333)?;
8382

84-
#[cfg(feature = "x11bridge")]
85-
let direct_x11 = setup_x11_forwarding(run_path)?;
86-
#[cfg(not(feature = "x11bridge"))]
87-
let direct_x11 = false;
88-
89-
if !direct_x11 {
83+
if !setup_x11_forwarding(run_path)? {
9084
// Will not return if successful.
9185
exec_sommelier(&options.command, &options.command_args)
9286
.context("Failed to execute sommelier")?;

crates/muvm/src/guest/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@ pub mod net;
55
pub mod socket;
66
pub mod sommelier;
77
pub mod user;
8-
#[cfg(feature = "x11bridge")]
98
pub mod x11;

0 commit comments

Comments
 (0)