Skip to content

Commit d28ab8c

Browse files
ArcaneNibblemarcan
authored andcommitted
jpeg: Figured out how to activate tiling
Signed-off-by: R <[email protected]>
1 parent b2a0352 commit d28ab8c

2 files changed

Lines changed: 10 additions & 9 deletions

File tree

proxyclient/experiments/jpeg.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ def set_default_regs(param1=0):
406406
jpeg.CHROMA_DOUBLE_H.val = 0
407407
jpeg.CHROMA_QUADRUPLE_H.val = 0
408408
jpeg.CHROMA_DOUBLE_V.val = 0
409-
jpeg.REG_0x15c.val = 0
409+
jpeg.PLANAR_CHROMA_HALVING.val = 0
410410
jpeg.PX_USE_PLANE1.val = 0
411411
jpeg.PX_TILES_W.val = 1
412412
jpeg.PX_TILES_H.val = 1
@@ -441,9 +441,9 @@ def set_default_regs(param1=0):
441441
jpeg.REG_0x118.val = 0
442442
jpeg.REG_0x11c.val = 0
443443
jpeg.REG_0x120.val = 0
444-
jpeg.REG_0x124.val = 0
445-
jpeg.REG_0x128.val = 0
446-
jpeg.REG_0x12c.val = 0
444+
jpeg.TILING_ENABLE.val = 0
445+
jpeg.TILING_PLANE0.val = 0
446+
jpeg.TILING_PLANE1.val = 0
447447
jpeg.DECODE_MACROBLOCKS_W.val = 0
448448
jpeg.DECODE_MACROBLOCKS_H.val = 0
449449
jpeg.SCALE_FACTOR.val = 0

proxyclient/m1n1/hw/jpeg.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,10 +177,11 @@ class JPEGRegs(RegMap):
177177
REG_0x11c = 0x11c, Register32
178178

179179
REG_0x120 = 0x120, Register32
180-
# driver mentions surface tiling, but this doesn't seem to work???
181-
REG_0x124 = 0x124, Register32
182-
REG_0x128 = 0x128, Register32
183-
REG_0x12c = 0x12c, Register32
180+
181+
# details not understood yet
182+
TILING_ENABLE = 0x124, Register32
183+
TILING_PLANE0 = 0x128, Register32
184+
TILING_PLANE1 = 0x12c, Register32
184185

185186
DECODE_MACROBLOCKS_W = 0x130, Register32
186187
DECODE_MACROBLOCKS_H = 0x134, Register32
@@ -198,7 +199,7 @@ class JPEGRegs(RegMap):
198199
RGBA_ORDER = 0x154, Register32
199200
RGBA_ALPHA = 0x158, Register32
200201

201-
REG_0x15c = 0x15c, Register32
202+
PLANAR_CHROMA_HALVING = 0x15c, Register32
202203

203204
REG_0x160 = 0x160, Register32
204205
REG_0x164 = 0x164, Register32

0 commit comments

Comments
 (0)