Skip to content

Commit c1b0b39

Browse files
marcaneiln
authored andcommitted
kboot: Make dt_get_or_add_reserved_mem mutate existing nodes
This means we can use it with pre-created nodes in the DT. Signed-off-by: Hector Martin <[email protected]> Signed-off-by: Eileen Yoon <[email protected]>
1 parent deb2807 commit c1b0b39

1 file changed

Lines changed: 12 additions & 13 deletions

File tree

src/kboot.c

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1208,21 +1208,20 @@ static int dt_get_or_add_reserved_mem(const char *node_name, const char *compat,
12081208
bail("FDT: '/reserved-memory' not found\n");
12091209

12101210
int node = fdt_subnode_offset(dt, resv_node, node_name);
1211-
if (node >= 0)
1212-
return node;
1213-
1214-
node = fdt_add_subnode(dt, resv_node, node_name);
1215-
if (node < 0)
1216-
bail("FDT: failed to add node '%s' to '/reserved-memory'\n", node_name);
1211+
if (node < 0) {
1212+
node = fdt_add_subnode(dt, resv_node, node_name);
1213+
if (node < 0)
1214+
bail("FDT: failed to add node '%s' to '/reserved-memory'\n", node_name);
12171215

1218-
uint32_t phandle;
1219-
ret = fdt_generate_phandle(dt, &phandle);
1220-
if (ret)
1221-
bail("FDT: failed to generate phandle: %d\n", ret);
1216+
uint32_t phandle;
1217+
ret = fdt_generate_phandle(dt, &phandle);
1218+
if (ret)
1219+
bail("FDT: failed to generate phandle: %d\n", ret);
12221220

1223-
ret = fdt_setprop_u32(dt, node, "phandle", phandle);
1224-
if (ret != 0)
1225-
bail("FDT: couldn't set '%s.phandle' property: %d\n", node_name, ret);
1221+
ret = fdt_setprop_u32(dt, node, "phandle", phandle);
1222+
if (ret != 0)
1223+
bail("FDT: couldn't set '%s.phandle' property: %d\n", node_name, ret);
1224+
}
12261225

12271226
u64 reg[2] = {cpu_to_fdt64(paddr), cpu_to_fdt64(size)};
12281227
ret = fdt_setprop(dt, node, "reg", reg, sizeof(reg));

0 commit comments

Comments
 (0)