Skip to content

Commit 5a632ba

Browse files
committed
kboot: Make dt_get_or_add_reserved_mem mutate existing nodes
This means we can use it with pre-created nodes in the DT. Signed-off-by: Hector Martin <[email protected]>
1 parent 4ae2357 commit 5a632ba

1 file changed

Lines changed: 12 additions & 13 deletions

File tree

src/kboot.c

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1264,21 +1264,20 @@ static int dt_get_or_add_reserved_mem(const char *node_name, const char *compat,
12641264
bail("FDT: '/reserved-memory' not found\n");
12651265

12661266
int node = fdt_subnode_offset(dt, resv_node, node_name);
1267-
if (node >= 0)
1268-
return node;
1269-
1270-
node = fdt_add_subnode(dt, resv_node, node_name);
1271-
if (node < 0)
1272-
bail("FDT: failed to add node '%s' to '/reserved-memory'\n", node_name);
1267+
if (node < 0) {
1268+
node = fdt_add_subnode(dt, resv_node, node_name);
1269+
if (node < 0)
1270+
bail("FDT: failed to add node '%s' to '/reserved-memory'\n", node_name);
12731271

1274-
uint32_t phandle;
1275-
ret = fdt_generate_phandle(dt, &phandle);
1276-
if (ret)
1277-
bail("FDT: failed to generate phandle: %d\n", ret);
1272+
uint32_t phandle;
1273+
ret = fdt_generate_phandle(dt, &phandle);
1274+
if (ret)
1275+
bail("FDT: failed to generate phandle: %d\n", ret);
12781276

1279-
ret = fdt_setprop_u32(dt, node, "phandle", phandle);
1280-
if (ret != 0)
1281-
bail("FDT: couldn't set '%s.phandle' property: %d\n", node_name, ret);
1277+
ret = fdt_setprop_u32(dt, node, "phandle", phandle);
1278+
if (ret != 0)
1279+
bail("FDT: couldn't set '%s.phandle' property: %d\n", node_name, ret);
1280+
}
12821281

12831282
u64 reg[2] = {cpu_to_fdt64(paddr), cpu_to_fdt64(size)};
12841283
ret = fdt_setprop(dt, node, "reg", reg, sizeof(reg));

0 commit comments

Comments
 (0)