Skip to content

Commit e180f55

Browse files
jannaumarcan
authored andcommitted
drm/apple: Remove simpledrm framebuffer before DRM device alloc
Should result in drm apple to be registered as first DRM device replacing simpledrm. Should resolve problems with userspace assuming that card0 is the main displays device. Signed-off-by: Janne Grunau <[email protected]>
1 parent efa5a06 commit e180f55

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

drivers/gpu/drm/apple/apple_drv.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -467,6 +467,14 @@ static int apple_drm_init(struct device *dev)
467467
if (ret)
468468
return ret;
469469

470+
fb_size = fb_r.end - fb_r.start + 1;
471+
ret = drm_aperture_remove_conflicting_framebuffers(fb_r.start, fb_size,
472+
false, &apple_drm_driver);
473+
if (ret) {
474+
dev_err(dev, "Failed remove fb: %d\n", ret);
475+
goto err_unbind;
476+
}
477+
470478
apple = devm_drm_dev_alloc(dev, &apple_drm_driver,
471479
struct apple_drm_private, drm);
472480
if (IS_ERR(apple))
@@ -478,14 +486,6 @@ static int apple_drm_init(struct device *dev)
478486
if (ret)
479487
return ret;
480488

481-
fb_size = fb_r.end - fb_r.start + 1;
482-
ret = drm_aperture_remove_conflicting_framebuffers(fb_r.start, fb_size,
483-
false, &apple_drm_driver);
484-
if (ret) {
485-
dev_err(dev, "Failed remove fb: %d\n", ret);
486-
goto err_unbind;
487-
}
488-
489489
ret = drmm_mode_config_init(&apple->drm);
490490
if (ret)
491491
goto err_unload;

0 commit comments

Comments
 (0)