Skip to content

Commit d6a25e6

Browse files
Carlos Llamasgregkh
authored andcommitted
iommu/sva: include mmu_notifier.h header
commit 4b5c493 upstream. A call to mmu_notifier_arch_invalidate_secondary_tlbs() was introduced in commit e37d5a2 ("iommu/sva: invalidate stale IOTLB entries for kernel address space") but without explicitly adding its corresponding header file <linux/mmu_notifier.h>. This was evidenced while trying to enable compile testing support for IOMMU_SVA: config IOMMU_SVA select IOMMU_MM_DATA - bool + bool "Shared Virtual Addressing" if COMPILE_TEST The thing is for certain architectures this header file is indirectly included via <asm/tlbflush.h>. However, for others such as 32-bit arm the header is missing and it results in a build failure: $ make ARCH=arm allmodconfig [...] drivers/iommu/iommu-sva.c:340:3: error: call to undeclared function 'mmu_notifier_arch_invalidate_secondary_tlbs' [...] 340 | mmu_notifier_arch_invalidate_secondary_tlbs(iommu_mm->mm, start, end); | ^ Fix this by including the appropriate header file. Link: https://lkml.kernel.org/r/[email protected] Fixes: e37d5a2 ("iommu/sva: invalidate stale IOTLB entries for kernel address space") Signed-off-by: Carlos Llamas <[email protected]> Cc: Baolu Lu <[email protected]> Cc: Jason Gunthorpe <[email protected]> Cc: Joerg Roedel <[email protected]> Cc: Kevin Tian <[email protected]> Cc: Robin Murphy <[email protected]> Cc: Vasant Hegde <[email protected]> Cc: Will Deacon <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 2d1bf4a commit d6a25e6

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/iommu/iommu-sva.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Helpers for IOMMU drivers implementing SVA
44
*/
55
#include <linux/mmu_context.h>
6+
#include <linux/mmu_notifier.h>
67
#include <linux/mutex.h>
78
#include <linux/sched/mm.h>
89
#include <linux/iommu.h>

0 commit comments

Comments
 (0)