Skip to content

Commit 9f26934

Browse files
committed
Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
Pull SCSI fixes from James Bottomley: "Small changes in drivers only, no core changes. The firewire one fixes a user controlled overflow (but I still can't see how it could be exploited)" * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: scsi: ufs: amd-versal2: Fix PHY initialization in HCE enable notify scsi: firewire: sbp-target: Fix overflow in sbp_make_tpg() scsi: be2iscsi: Fix a memory leak in beiscsi_boot_get_sinfo() scsi: qla2xxx: edif: Fix dma_free_coherent() size
2 parents c00a879 + 0444568 commit 9f26934

4 files changed

Lines changed: 5 additions & 4 deletions

File tree

drivers/scsi/be2iscsi/be_mgmt.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,6 +1025,7 @@ unsigned int beiscsi_boot_get_sinfo(struct beiscsi_hba *phba)
10251025
&nonemb_cmd->dma,
10261026
GFP_KERNEL);
10271027
if (!nonemb_cmd->va) {
1028+
free_mcc_wrb(ctrl, tag);
10281029
mutex_unlock(&ctrl->mbox_lock);
10291030
return 0;
10301031
}

drivers/scsi/qla2xxx/qla_os.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4489,7 +4489,7 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len,
44894489
fail_elsrej:
44904490
dma_pool_destroy(ha->purex_dma_pool);
44914491
fail_flt:
4492-
dma_free_coherent(&ha->pdev->dev, SFP_DEV_SIZE,
4492+
dma_free_coherent(&ha->pdev->dev, sizeof(struct qla_flt_header) + FLT_REGIONS_SIZE,
44934493
ha->flt, ha->flt_dma);
44944494

44954495
fail_flt_buffer:

drivers/target/sbp/sbp_target.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1960,12 +1960,12 @@ static struct se_portal_group *sbp_make_tpg(struct se_wwn *wwn,
19601960
container_of(wwn, struct sbp_tport, tport_wwn);
19611961

19621962
struct sbp_tpg *tpg;
1963-
unsigned long tpgt;
1963+
u16 tpgt;
19641964
int ret;
19651965

19661966
if (strstr(name, "tpgt_") != name)
19671967
return ERR_PTR(-EINVAL);
1968-
if (kstrtoul(name + 5, 10, &tpgt) || tpgt > UINT_MAX)
1968+
if (kstrtou16(name + 5, 10, &tpgt))
19691969
return ERR_PTR(-EINVAL);
19701970

19711971
if (tport->tpg) {

drivers/ufs/host/ufs-amd-versal2.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ static int ufs_versal2_hce_enable_notify(struct ufs_hba *hba,
367367
{
368368
int ret = 0;
369369

370-
if (status == PRE_CHANGE) {
370+
if (status == POST_CHANGE) {
371371
ret = ufs_versal2_phy_init(hba);
372372
if (ret)
373373
dev_err(hba->dev, "Phy init failed (%d)\n", ret);

0 commit comments

Comments
 (0)