Skip to content

Commit 97c6280

Browse files
hoshinolinamarcan
authored andcommitted
drm/asahi: queue: Alocate the NotifierList as shared
macOS does it this way, and the firmware needs it (no cache management!) Fixes firmware crashes with piglit with high concurrency. Signed-off-by: Asahi Lina <[email protected]>
1 parent d59eeb8 commit 97c6280

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

  • drivers/gpu/drm/asahi/queue

drivers/gpu/drm/asahi/queue/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,8 @@ impl Queue::ver {
381381

382382
let data = dev.data();
383383

384-
let mut notifier_list = alloc.private.new_default::<fw::event::NotifierList>()?;
384+
// Must be shared, no cache management on this one!
385+
let mut notifier_list = alloc.shared.new_default::<fw::event::NotifierList>()?;
385386

386387
let self_ptr = notifier_list.weak_pointer();
387388
notifier_list.with_mut(|raw, _inner| {

0 commit comments

Comments
 (0)