ASoC: amd: fix memory leak in acp3x pdm dma ops

chrisbainbridge · broonie · commit 7f67ba5413f9 · 2026-02-04T11:29:56.000Z
Fixes: 4a767b1 ("ASoC: amd: add acp3x pdm driver dma ops") Signed-off-by: Chris Bainbridge <chris.bainbridge@gmail.com> Link: https://patch.msgid.link/20260202205034.7697-1-chris.bainbridge@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/acp3x-pdm-dma.c
@@ -301,9 +301,11 @@ static int acp_pdm_dma_close(struct snd_soc_component *component,
 			     struct snd_pcm_substream *substream)
 {
 	struct pdm_dev_data *adata = dev_get_drvdata(component->dev);
+	struct pdm_stream_instance *rtd = substream->runtime->private_data;
 
 	disable_pdm_interrupts(adata->acp_base);
 	adata->capture_stream = NULL;
+	kfree(rtd);
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -301,9 +301,11 @@ static int acp_pdm_dma_close(struct snd_soc_component *component,`
`301`	`301`	`struct snd_pcm_substream *substream)`
`302`	`302`	`{`
`303`	`303`	`struct pdm_dev_data *adata = dev_get_drvdata(component->dev);`
	`304`	`+ struct pdm_stream_instance *rtd = substream->runtime->private_data;`
`304`	`305`
`305`	`306`	`disable_pdm_interrupts(adata->acp_base);`
`306`	`307`	`adata->capture_stream = NULL;`
	`308`	`+ kfree(rtd);`
`307`	`309`	`return 0;`
`308`	`310`	`}`
`309`	`311`