Skip to content

Commit 500dad4

Browse files
mwajdeczrodrigovivi
authored andcommitted
drm/xe/vf: Don't expose sysfs attributes not applicable for VFs
VFs can't read BMG_PCIE_CAP(0x138340) register nor access PCODE (already guarded by the info.skip_pcode flag) so we shouldn't expose attributes that require any of them to avoid errors like: [] xe 0000:03:00.1: [drm] Tile0: GT0: VF is trying to read an \ inaccessible register 0x138340+0x0 [] RIP: 0010:xe_gt_sriov_vf_read32+0x6c2/0x9a0 [xe] [] Call Trace: [] xe_mmio_read32+0x110/0x280 [xe] [] auto_link_downgrade_capable_show+0x2e/0x70 [xe] [] dev_attr_show+0x1a/0x70 [] sysfs_kf_seq_show+0xaa/0x120 [] kernfs_seq_show+0x41/0x60 Fixes: 0e414bf ("drm/xe: Expose PCIe link downgrade attributes") Fixes: cdc36b6 ("drm/xe: Expose fan control and voltage regulator version") Signed-off-by: Michal Wajdeczko <[email protected]> Cc: Lucas De Marchi <[email protected]> Cc: Lukasz Laguna <[email protected]> Reviewed-by: Raag Jadav <[email protected]> Reviewed-by: Lucas De Marchi <[email protected]> Link: https://lore.kernel.org/r/[email protected] (cherry picked from commit a2d6223) Signed-off-by: Rodrigo Vivi <[email protected]>
1 parent 07e27ad commit 500dad4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/xe/xe_device_sysfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ int xe_device_sysfs_init(struct xe_device *xe)
308308
return ret;
309309
}
310310

311-
if (xe->info.platform == XE_BATTLEMAGE) {
311+
if (xe->info.platform == XE_BATTLEMAGE && !IS_SRIOV_VF(xe)) {
312312
ret = sysfs_create_files(&dev->kobj, auto_link_downgrade_attrs);
313313
if (ret)
314314
goto cleanup;

0 commit comments

Comments
 (0)