Skip to content

Commit 484ec03

Browse files
committed
iommu: apple-dart: Clear stream error indicator bits for T8110 DARTs
These registers exist at least on the t602x variant, and if not cleared the IRQ will never clear. Signed-off-by: Hector Martin <[email protected]>
1 parent 50080ef commit 484ec03

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

drivers/iommu/apple-dart.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,8 @@
122122
#define DART_T8110_ERROR_ADDR_LO 0x170
123123
#define DART_T8110_ERROR_ADDR_HI 0x174
124124

125+
#define DART_T8110_ERROR_STREAMS 0x1c0
126+
125127
#define DART_T8110_PROTECT 0x200
126128
#define DART_T8110_UNPROTECT 0x204
127129
#define DART_T8110_PROTECT_LOCK 0x208
@@ -1188,6 +1190,7 @@ static irqreturn_t apple_dart_t8110_irq(int irq, void *dev)
11881190
u32 addr_hi = readl(dart->regs + DART_T8110_ERROR_ADDR_HI);
11891191
u64 addr = addr_lo | (((u64)addr_hi) << 32);
11901192
u8 stream_idx = FIELD_GET(DART_T8110_ERROR_STREAM, error);
1193+
int i;
11911194

11921195
if (!(error & DART_T8110_ERROR_FLAG))
11931196
return IRQ_NONE;
@@ -1214,6 +1217,9 @@ static irqreturn_t apple_dart_t8110_irq(int irq, void *dev)
12141217
error, stream_idx, error_code, fault_name, addr);
12151218

12161219
writel(error, dart->regs + DART_T8110_ERROR);
1220+
for (i = 0; i < BITS_TO_U32(dart->num_streams); i++)
1221+
writel(U32_MAX, dart->regs + DART_T8110_ERROR_STREAMS + 4 * i);
1222+
12171223
return IRQ_HANDLED;
12181224
}
12191225

0 commit comments

Comments
 (0)