Revert "usb: typec: tipd: Do not request duplicate role switches"

jannau · jannau · commit 481d2c486faa · 2026-01-09T20:50:04.000+01:00
This reverts commit 2ad915e. Issue solved in dwc3-apple instead. Signed-off-by: Janne Grunau <j@jannau.net>
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
@@ -841,8 +841,7 @@ static void cd321x_update_work(struct work_struct *work)
 	cd321x_typec_update_mode(tps, &st);
 
 	/* Launch the USB role switch */
-	if ((new_role != old_role) || was_disconnected)
-		usb_role_switch_set_role(tps->role_sw, new_role);
+	usb_role_switch_set_role(tps->role_sw, new_role);
 
 	power_supply_changed(tps->psy);
 }

Original file line number	Diff line number	Diff line change
`@@ -841,8 +841,7 @@ static void cd321x_update_work(struct work_struct *work)`
`841`	`841`	`cd321x_typec_update_mode(tps, &st);`
`842`	`842`
`843`	`843`	`/* Launch the USB role switch */`
`844`		`- if ((new_role != old_role) \|\| was_disconnected)`
`845`		`- usb_role_switch_set_role(tps->role_sw, new_role);`
	`844`	`+ usb_role_switch_set_role(tps->role_sw, new_role);`
`846`	`845`
`847`	`846`	`power_supply_changed(tps->psy);`
`848`	`847`	`}`