Skip to content

Commit 372504e

Browse files
ashutoshxgregkh
authored andcommitted
Revert "drm/xe/xe_guc_ads: save/restore OA registers and allowlist regs"
commit 0191fdd upstream. This reverts commit 55858fa. '55858fa7eb2f ("drm/xe/xe_guc_ads: save/restore OA registers and allowlist regs")' was not properly reviewed and also causes dmesg asserts in CI. Revert it. Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3295 Fixes: 55858fa ("drm/xe/xe_guc_ads: save/restore OA registers and allowlist regs") Signed-off-by: Ashutosh Dixit <[email protected]> Reviewed-by: Jonathan Cavitt <[email protected]> Signed-off-by: Matt Roper <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent aa28959 commit 372504e

1 file changed

Lines changed: 0 additions & 14 deletions

File tree

drivers/gpu/drm/xe/xe_guc_ads.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include "regs/xe_engine_regs.h"
1414
#include "regs/xe_gt_regs.h"
1515
#include "regs/xe_guc_regs.h"
16-
#include "regs/xe_oa_regs.h"
1716
#include "xe_bo.h"
1817
#include "xe_gt.h"
1918
#include "xe_gt_ccs_mode.h"
@@ -602,11 +601,6 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads,
602601
guc_mmio_regset_write_one(ads, regset_map, e->reg, count++);
603602
}
604603

605-
for (i = 0; i < RING_MAX_NONPRIV_SLOTS; i++)
606-
guc_mmio_regset_write_one(ads, regset_map,
607-
RING_FORCE_TO_NONPRIV(hwe->mmio_base, i),
608-
count++);
609-
610604
/* Wa_1607983814 */
611605
if (needs_wa_1607983814(xe) && hwe->class == XE_ENGINE_CLASS_RENDER) {
612606
for (i = 0; i < LNCFCMOCS_REG_COUNT; i++) {
@@ -615,14 +609,6 @@ static unsigned int guc_mmio_regset_write(struct xe_guc_ads *ads,
615609
}
616610
}
617611

618-
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL0, count++);
619-
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL1, count++);
620-
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL2, count++);
621-
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL3, count++);
622-
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL4, count++);
623-
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL5, count++);
624-
guc_mmio_regset_write_one(ads, regset_map, EU_PERF_CNTL6, count++);
625-
626612
return count;
627613
}
628614

0 commit comments

Comments
 (0)