scripts/tracepoint-update: Fix memory leak in add_string() on failure

When realloc() fails in add_string(), the function returns -1 but leaves
*vals pointing to the previously allocated memory. This can cause memory
leaks in callers like make_trace_array() that return on error without
freeing the partially built array.

Fix this by freeing *vals and setting it to NULL when realloc() fails.
This makes the error handling self-contained in add_string() so callers
don't need to handle cleanup on failure.

This bug is found by my static analysis tool and my code review.

Cc: Masami Hiramatsu <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
Fixes: e30f8e6 ("tracing: Add a tracepoint verification check at build time")
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Weigang He <[email protected]>
Signed-off-by: Steven Rostedt (Google) <[email protected]>

Author: Weigang He

scripts/tracepoint-update.c

@@ -49,6 +49,8 @@ static int add_string(const char *str, const char ***vals, int *count)
 		array = realloc(array, sizeof(char *) * size);
 		if (!array) {
 			fprintf(stderr, "Failed memory allocation\n");
+			free(*vals);
+			*vals = NULL;
 			return -1;
 		}
 		*vals = array;