@@ -481,8 +481,8 @@ static int nvmem_cell_info_to_nvmem_cell_entry_nodup(struct nvmem_device *nvmem,
481481 cell -> np = info -> np ;
482482
483483 if (cell -> nbits )
484- cell -> bytes = DIV_ROUND_UP (cell -> nbits + cell -> bit_offset ,
485- BITS_PER_BYTE );
484+ cell -> bytes = round_up ( DIV_ROUND_UP (cell -> nbits + cell -> bit_offset ,
485+ BITS_PER_BYTE ), nvmem -> word_size ) ;
486486
487487 if (!IS_ALIGNED (cell -> offset , nvmem -> stride )) {
488488 dev_err (& nvmem -> dev ,
@@ -1526,15 +1526,23 @@ EXPORT_SYMBOL_GPL(nvmem_cell_put);
15261526static void nvmem_shift_read_buffer_in_place (struct nvmem_cell_entry * cell , void * buf )
15271527{
15281528 u8 * p , * b ;
1529- int i , extra , bit_offset = cell -> bit_offset ;
1529+ int i , padding , extra , bit_offset = cell -> bit_offset ;
1530+ int bytes = cell -> bytes ;
15301531
15311532 p = b = buf ;
15321533 if (bit_offset ) {
1534+ padding = bit_offset /8 ;
1535+ if (padding ) {
1536+ memmove (buf , buf + padding , bytes - padding );
1537+ bit_offset -= BITS_PER_BYTE * padding ;
1538+ bytes -= padding ;
1539+ }
1540+
15331541 /* First shift */
15341542 * b ++ >>= bit_offset ;
15351543
15361544 /* setup rest of the bytes if any */
1537- for (i = 1 ; i < cell -> bytes ; i ++ ) {
1545+ for (i = 1 ; i < bytes ; i ++ ) {
15381546 /* Get bits from next byte and shift them towards msb */
15391547 * p |= * b << (BITS_PER_BYTE - bit_offset );
15401548
@@ -1547,7 +1555,7 @@ static void nvmem_shift_read_buffer_in_place(struct nvmem_cell_entry *cell, void
15471555 }
15481556
15491557 /* result fits in less bytes */
1550- extra = cell -> bytes - DIV_ROUND_UP (cell -> nbits , BITS_PER_BYTE );
1558+ extra = bytes - DIV_ROUND_UP (cell -> nbits , BITS_PER_BYTE );
15511559 while (-- extra >= 0 )
15521560 * p -- = 0 ;
15531561
0 commit comments