Skip to content

Commit 15f4442

Browse files
jannaumarcan
authored andcommitted
PCI: apple: Set only available ports up
Fixes "interrupt-map" parsing in of_irq_parse_raw() which takes the node's availability into account. This became apparent after disabling unused PCIe ports in the Apple silicon device trees instead of disabling them. Link: https://lore.kernel.org/asahi/20230214-apple_dts_pcie_disable_unused-v1-0-5ea0d3ddcde3@jannau.net/ Link: https://lore.kernel.org/asahi/[email protected]/ Fixes: 1e33888 ("PCI: apple: Add initial hardware bring-up") Cc: [email protected] Signed-off-by: Janne Grunau <[email protected]>
1 parent b61b039 commit 15f4442

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/pci/controller/pcie-apple.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -828,7 +828,7 @@ static int apple_pcie_init(struct pci_config_window *cfg)
828828
cfg->priv = pcie;
829829
INIT_LIST_HEAD(&pcie->ports);
830830

831-
for_each_child_of_node(dev->of_node, of_port) {
831+
for_each_available_child_of_node(dev->of_node, of_port) {
832832
ret = apple_pcie_setup_port(pcie, of_port);
833833
if (ret) {
834834
dev_err(pcie->dev, "Port %pOF setup fail: %d\n", of_port, ret);

0 commit comments

Comments
 (0)