Skip to content

Commit 070affc

Browse files
hoshinolinamarcan
authored andcommitted
media: apple: isp: Option to use CMD_STOP (ifdeffed out)
Signed-off-by: Asahi Lina <[email protected]>
1 parent 54ddf21 commit 070affc

1 file changed

Lines changed: 17 additions & 2 deletions

File tree

  • drivers/media/platform/apple/isp

drivers/media/platform/apple/isp/isp-fw.c

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -593,11 +593,26 @@ static int isp_stop_command_processor(struct apple_isp *isp)
593593
{
594594
int retries;
595595

596+
#if 0
597+
int res = isp_cmd_stop(isp, 0);
598+
if (res) {
599+
isp_err(isp, "isp_cmd_stop() failed\n");
600+
return res;
601+
}
602+
596603
/* Wait for ISP_GPIO_0 to 0xf7fbdff9 -> 0x8042006 */
597604
isp_gpio_write32(isp, ISP_GPIO_0, 0xf7fbdff9);
598605

599-
/* Their CISP_CMD_STOP implementation is buggy */
600-
isp_cmd_suspend(isp);
606+
isp_cmd_power_down(isp);
607+
#else
608+
isp_gpio_write32(isp, ISP_GPIO_0, 0xf7fbdff9);
609+
610+
int res = isp_cmd_suspend(isp);
611+
if (res) {
612+
isp_err(isp, "isp_cmd_suspend() failed\n");
613+
return res;
614+
}
615+
#endif
601616

602617
for (retries = 0; retries < ISP_FIRMWARE_MAX_TRIES; retries++) {
603618
u32 val = isp_gpio_read32(isp, ISP_GPIO_0);

0 commit comments

Comments
 (0)