scsi: qla4xxx: Fix missing DMA mapping error in qla4xxx_alloc_pdu()

Thomas-fourier · martinkpetersen · commit 00f452a1b084 · 2025-06-23T13:23:45.000-04:00
dma_map_XXX() can fail and should be tested for errors with dma_mapping_error(). Fixes: b3a271a ("[SCSI] qla4xxx: support iscsiadm session mgmt") Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com> Link: https://lore.kernel.org/r/20250618071742.21822-2-fourier.thomas@gmail.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
@@ -3420,6 +3420,8 @@ static int qla4xxx_alloc_pdu(struct iscsi_task *task, uint8_t opcode)
 		task_data->data_dma = dma_map_single(&ha->pdev->dev, task->data,
 						     task->data_count,
 						     DMA_TO_DEVICE);
+		if (dma_mapping_error(&ha->pdev->dev, task_data->data_dma))
+			return -ENOMEM;
 	}
 
 	DEBUG2(ql4_printk(KERN_INFO, ha, "%s: MaxRecvLen %u, iscsi hrd %d\n",

Original file line number	Diff line number	Diff line change
`@@ -3420,6 +3420,8 @@ static int qla4xxx_alloc_pdu(struct iscsi_task *task, uint8_t opcode)`
`3420`	`3420`	`task_data->data_dma = dma_map_single(&ha->pdev->dev, task->data,`
`3421`	`3421`	`task->data_count,`
`3422`	`3422`	`DMA_TO_DEVICE);`
	`3423`	`+ if (dma_mapping_error(&ha->pdev->dev, task_data->data_dma))`
	`3424`	`+ return -ENOMEM;`
`3423`	`3425`	`}`
`3424`	`3426`
`3425`	`3427`	`DEBUG2(ql4_printk(KERN_INFO, ha, "%s: MaxRecvLen %u, iscsi hrd %d\n",`