Apple really screwed this one up. :(

Signed-off-by: Hector Martin <[email protected]>

Author: marcan

src/main.py

@@ -21,6 +21,9 @@
 MIN_MACOS_VERSION = "13.5"
 MIN_MACOS_VERSION_EXPERT = "12.3"
 
+# Apple...
+BUGGY_SFR_MIN = "14.0"
+
 @dataclass
 class IPSW:
     version: str
@@ -46,6 +49,21 @@ class Device:
     0x6022: "13.4",     # T6022, M2 Ultra
 }
 
+PROMOTION_DEVICES = {
+    "j314cap",
+    "j314sap",
+    "j316cap",
+    "j316sap",
+    "j414cap",
+    "j414sap",
+    "j416cap",
+    "j416sap",
+    "j514cap", # Speculative
+    "j514sap",
+    "j516cap",
+    "j516sap",
+}
+
 DEVICES = {
     "j274ap":   Device("11.0", False),  # Mac mini (M1, 2020)
     "j293ap":   Device("11.0", False),  # MacBook Pro (13-inch, M1, 2020)
@@ -825,6 +843,47 @@ def main(self):
         self.sysinfo = system.SystemInfo()
         self.sysinfo.show()
         print()
+
+        if self.sysinfo.sfr_full_ver != self.sysinfo.sros_full_ver:
+            p_error("Mismatched System Firmware / System Recovery detected!")
+            print()
+            p_error("Critical bugs in Apple's update process introduced in macOS Sonoma 14.0 and")
+            p_error("macOS Ventura 13.6 can cause your System Recovery to not be updated properly.")
+            p_error("It is not safe to install a new OS on this computer until this is resolved.")
+            p_error("Please apply all macOS updates available and try again. If the problem remains,")
+            p_error("you will have to wait until Apple fixes their buggy update process.")
+            print()
+            p_error("More information:")
+            p_error("https://github.com/AsahiLinux/docs/wiki/macOS-Sonoma-Boot-Failures")
+            print()
+            sys.exit(1)
+
+        if (self.sysinfo.device_class in PROMOTION_DEVICES and
+            split_ver(self.sysinfo.sfr_ver) > split_ver(BUGGY_SFR_MIN)):
+            p_warning( "WARNING: You have a MacBook Pro with a ProMotion display, and you have")
+            p_warning(f"System Firmware version {BUGGY_SFR_MIN} or newer. These firmware versions are")
+            p_warning( "buggy and will NOT correctly boot older versions of macOS, nor Asahi Linux,")
+            p_warning( "if the display is configured for a refresh rate other than ProMotion (120Hz).")
+            print()
+            hz = self.sysinfo.get_refresh_rate()
+            p_info(f"  Current refresh rate: {col()}{hz}")
+            print()
+            if hz != "120.00Hz":
+                p_error("Your display is not set to ProMotion mode (120 Hz). Please change your")
+                p_error("display refresh rate to ProMotion mode in System Settings and try again.")
+                print()
+                p_error("It is not safe to multi-boot with a non-ProMotion refresh rate until")
+                p_error("Apple fixes this bug.")
+                print()
+                sys.exit(1)
+
+            p_warning("You are currently using ProMotion mode. You may continue the install")
+            p_warning("but you MUST NOT change the refresh rate until Apple fixes this bug.")
+            p_warning("There is nothing we can do on our end. Proceed at your own risk.")
+            print()
+            if not self.yesno("Continue anyway?"):
+                sys.exit(0)
+
         self.chip_min_ver = CHIP_MIN_VER.get(self.sysinfo.chip_id, None)
         self.device = DEVICES.get(self.sysinfo.device_class, None)
         if not self.chip_min_ver or not self.device or (self.device.expert_only and not self.expert):

src/system.py

@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: MIT
-import base64, plistlib, struct, subprocess, logging
+import base64, plistlib, struct, subprocess, logging, json
 
 from util import *
 
@@ -82,6 +82,17 @@ def fetch(self):
                 if consoleuser != "_mbsetupuser":
                     self.login_user = consoleuser
 
+        self.sros_full_ver = "0"
+
+        base = "/System/Volumes/iSCPreboot/SystemRecovery"
+        for p in os.listdir(base):
+            try:
+                v = self.get_restore_version(os.path.join(base, p, "RestoreVersion.plist"))
+            except Exception:
+                continue
+            if split_ver(v) > split_ver(self.sros_full_ver):
+                self.sros_full_ver = v
+
     def get_nvram_data(self):
         nvram_data = subprocess.run(["nvram", "-p"],
                                     stdout=subprocess.PIPE, check=True).stdout
@@ -129,12 +140,13 @@ def show(self):
         p_info(f"  Default boot VGID: {col()}{self.default_boot}")
         p_info(f"  Boot mode: {col()}{self.boot_mode}")
         p_info(f"  OS version: {col()}{self.macos_ver} ({self.macos_build})")
-        p_info(f"  SFR version: {col()}{self.sfr_full_ver}")
-        p_info(f"  System rOS version: {col()}{self.sfr_ver} ({self.sfr_build})")
+        p_info(f"  Main firmware version: {col()}{self.sfr_ver} ({self.sfr_build})")
         if self.fsfr_ver:
-            p_info(f"  Fallback rOS version: {col()}{self.fsfr_ver} ({self.fsfr_build})")
+            p_info(f"  Fallback firmware version: {col()}{self.fsfr_ver} ({self.fsfr_build})")
         else:
-            p_info(f"  No Fallback rOS")
+            p_info(f"  No Fallback System Firmware / rOS")
+        p_info(f"  SFR version: {col()}{self.sfr_full_ver}")
+        p_info(f"  SystemRecovery version: {col()}{self.sros_full_ver}")
         p_info(f"  Login user: {col()}{self.login_user}")
 
     def get_child(self, obj, name):
@@ -155,3 +167,16 @@ def get_str(self, val):
     def get_int(self, val):
         return struct.unpack("<I", val)[0]
 
+    def get_refresh_rate(self):
+        j = subprocess.run(["system_profiler", "SPDisplaysDataType", "-json"],
+                           stdout=subprocess.PIPE, check=True).stdout
+
+        main_display = None
+        for a in json.loads(j)["SPDisplaysDataType"]:
+            for disp in a.get("spdisplays_ndrvs", []):
+                if disp["_name"] != "Color LCD":
+                    continue
+                assert main_display is None
+                main_display = disp
+
+        return main_display["_spdisplays_resolution"].split()[-1]