fix(tests): improve HTTPTransactionIT by using final variables and enhanced JSON payload formatting

Author: robfrank

server/src/test/java/com/arcadedb/server/HTTPTransactionIT.java

@@ -20,17 +20,19 @@
 
 import com.arcadedb.log.LogManager;
 import com.arcadedb.serializer.json.JSONObject;
-
 import org.junit.jupiter.api.Test;
 
-import java.io.*;
-import java.net.*;
-import java.util.*;
-import java.util.logging.*;
+import java.io.IOException;
+import java.io.OutputStreamWriter;
+import java.io.PrintWriter;
+import java.net.HttpURLConnection;
+import java.net.URL;
+import java.util.Base64;
+import java.util.HashMap;
+import java.util.logging.Level;
 
 import static com.arcadedb.schema.Property.RID_PROPERTY;
 import static com.arcadedb.server.http.HttpSessionManager.ARCADEDB_SESSION_ID;
-import static org.assertj.core.api.Assertions.*;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
@@ -166,7 +168,7 @@ public void simpleTx() throws Exception {
   public void checkUnique() throws Exception {
     testEachServer((serverIndex) -> {
       // BEGIN
-      HttpURLConnection connection = (HttpURLConnection) new URL(
+      final HttpURLConnection connection = (HttpURLConnection) new URL(
           "http://127.0.0.1:248" + serverIndex + "/api/v1/begin/graph").openConnection();
 
       connection.setRequestMethod("POST");
@@ -188,36 +190,38 @@ public void checkUnique() throws Exception {
       }
 
       // CREATE DOCUMENT
-      connection = (HttpURLConnection) new URL("http://127.0.0.1:248" + serverIndex + "/api/v1/command/graph").openConnection();
+      final HttpURLConnection connection2 = (HttpURLConnection) new URL(
+          "http://127.0.0.1:248" + serverIndex + "/api/v1/command/graph").openConnection();
 
-      connection.setRequestMethod("POST");
-      connection.setRequestProperty(ARCADEDB_SESSION_ID, sessionId);
-      connection.setRequestProperty("Authorization",
+      connection2.setRequestMethod("POST");
+      connection2.setRequestProperty(ARCADEDB_SESSION_ID, sessionId);
+      connection2.setRequestProperty("Authorization",
           "Basic " + Base64.getEncoder().encodeToString(("root:" + BaseGraphServerTest.DEFAULT_PASSWORD_FOR_TESTS).getBytes()));
 
-      final JSONObject payload = new JSONObject("{\"language\":\"sqlScript\", \"command\":\"" +//
-          "CREATE VERTEX TYPE eltdev;" +//
-          "CREATE PROPERTY eltdev.SN string;" +//
-          "CREATE INDEX ON eltdev (SN) UNIQUE;" +//
-          "CREATE VERTEX eltdev SET SN='bubu';" +//
-          "CREATE VERTEX eltdev SET SN='bubu';" +//
-          "\"}");
+      final JSONObject payload = new JSONObject("""
+          {"language":"sqlScript", "command":"
+          CREATE VERTEX TYPE eltdev;
+          CREATE PROPERTY eltdev.SN string;
+          CREATE INDEX ON eltdev (SN) UNIQUE;
+          CREATE VERTEX eltdev SET SN='bubu';
+          CREATE VERTEX eltdev SET SN='bubu';
+          "}""");
 
-      connection.setRequestMethod("POST");
-      connection.setDoOutput(true);
+      connection2.setRequestMethod("POST");
+      connection2.setDoOutput(true);
 
-      connection.connect();
+      connection2.connect();
 
       final PrintWriter pw = new PrintWriter(new OutputStreamWriter(connection.getOutputStream()));
       pw.write(payload.toString());
       pw.close();
 
-      assertThatThrownBy(() -> readResponse(connection))
+      assertThatThrownBy(() -> readResponse(connection2))
           .isInstanceOf(IOException.class);
 
-      String response = readError(connection);
-      assertThat(connection.getResponseCode()).isEqualTo(503);
-      connection.disconnect();
+      String response = readError(connection2);
+      assertThat(connection2.getResponseCode()).isEqualTo(503);
+      connection2.disconnect();
       assertThat(response.contains("DuplicatedKeyException")).isTrue();
     });
   }
@@ -257,7 +261,7 @@ public static void checkDocumentWasCreated(final String databaseName, final int
   public void errorMissingIsolationLevel() throws Exception {
     testEachServer((serverIndex) -> {
       // BEGIN
-      HttpURLConnection connection = (HttpURLConnection) new URL(
+      final HttpURLConnection connection = (HttpURLConnection) new URL(
           "http://127.0.0.1:248" + serverIndex + "/api/v1/begin/" + DATABASE_NAME).openConnection();
 
       connection.setRequestMethod("POST");