Fix shell script parameter duplication and improve consistency (#2622)

* Initial plan

* Fix shell script parameter duplication and improve consistency

- server.sh: Remove duplicate argument expansion ($* and "$@")
- console.sh: Add ARCADEDB_OPTS_MEMORY initialization for consistency
- restore.sh: Fix ARCADEDB_HOME check (console.sh -> restore.sh)
- restore.sh: Add ARCADEDB_OPTS_MEMORY initialization
- restore.sh: Fix argument expansion ($* -> "$@")

Co-authored-by: lvca <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: lvca <[email protected]>

Author: Copilot

package/src/main/scripts/console.sh

@@ -46,6 +46,10 @@ else
    JAVA=java
 fi
 
+# ARCADEDB memory options, default uses the available RAM. To set it to a specific value, like 2GB of heap, use "-Xms2G -Xmx2G"
+if [ -z "$ARCADEDB_OPTS_MEMORY" ]; then
+  ARCADEDB_OPTS_MEMORY=""
+fi
 
 if [ -z "$JAVA_OPTS_SCRIPT" ] ; then
     JAVA_OPTS_SCRIPT="-XX:+HeapDumpOnOutOfMemoryError \

package/src/main/scripts/restore.sh

@@ -32,7 +32,7 @@ done
 PRGDIR=`dirname "$PRG"`
 
 # Only set ARCADEDB_HOME if not already set
-[ -f "$ARCADEDB_HOME"/bin/console.sh ] || ARCADEDB_HOME=`cd "$PRGDIR/.." ; pwd`
+[ -f "$ARCADEDB_HOME"/bin/restore.sh ] || ARCADEDB_HOME=`cd "$PRGDIR/.." ; pwd`
 
 # Raspberry Pi check (Java VM does not run with -server argument on ARMv6)
 if [ `uname -m` != "armv6l" ]; then
@@ -46,6 +46,11 @@ else
    JAVA=java
 fi
 
+# ARCADEDB memory options, default uses the available RAM. To set it to a specific value, like 2GB of heap, use "-Xms2G -Xmx2G"
+if [ -z "$ARCADEDB_OPTS_MEMORY" ]; then
+  ARCADEDB_OPTS_MEMORY=""
+fi
+
 if [ -z "$JAVA_OPTS_SCRIPT" ] ; then
   JAVA_OPTS_SCRIPT="-XX:+HeapDumpOnOutOfMemoryError \
         --add-exports java.management/sun.management=ALL-UNNAMED \
@@ -62,4 +67,4 @@ exec "$JAVA" $JAVA_OPTS \
     $JAVA_OPTS_SCRIPT \
     $ARCADEDB_SETTINGS \
     -cp "$ARCADEDB_HOME/lib/*" \
-    $ARGS com.arcadedb.integration.restore.Restore $*
+    $ARGS com.arcadedb.integration.restore.Restore "$@"

package/src/main/scripts/server.sh

@@ -100,4 +100,4 @@ exec "$JAVA" $JAVA_OPTS \
   $ARCADEDB_JMX \
   $ARCADEDB_SETTINGS \
   -cp "$ARCADEDB_HOME/lib/*" \
-  $ARGS $* "$@" com.arcadedb.server.ArcadeDBServer
+  $ARGS "$@" com.arcadedb.server.ArcadeDBServer